Skip to content

Conversation

PBrunot
Copy link
Contributor

@PBrunot PBrunot commented Aug 15, 2023

Description of Change

This change adds a new board lilygo-t-display based on esp32. Board variants have 4 MB or 16 MB flash memory. All boards come with a TFT display. This board is the predecessor to the already included lilygo-t-display-s3.

Manufacturer Board webpage

Pinmap

Tests scenarios

I have tested my pull request with a Lilygo TDisplay HW rev 1.1 by configuring PlatformIO to use the platform in https://github.com/PBrunot/arduino-esp32#feature-lilygo-tdisplay as framework for arduino-esp32, and uploading a sketch to a destination board successfully. Testing sketch is using serial, TFT display over SPI.

platformio.used for testing

[env:T-Display]
platform = https://github.com/platformio/platform-espressif32.git
board = lilygo_t-display
framework = arduino
monitor_speed = 115200
build_flags = -D ARDUINO_LILYGO_T_DISPLAY_S3
platform_packages =
    framework-arduinoespressif32 @ https://github.com/PBrunot/arduino-esp32#feature-lilygo-tdisplay
lib_deps = 
	moononournation/GFX Library for Arduino@^1.3.7
	Wire
	SPI

Related links

This is required to add support in platformio for the same board, as per platformio esp32 policies : platformio/platform-espressif32#209

@CLAassistant
Copy link

CLAassistant commented Aug 15, 2023

CLA assistant check
All committers have signed the CLA.

this board is the predecessor to the already included lilygo-t-display-s3

added USB defines for t-display
@PBrunot PBrunot force-pushed the feature-lilygo-tdisplay branch from b1792f2 to 13b2586 Compare August 15, 2023 13:12
@VojtechBartoska VojtechBartoska added this to the 2.0.12 milestone Aug 16, 2023
@VojtechBartoska VojtechBartoska added the Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. label Aug 21, 2023
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PBrunot Please take a look on my comments. After its fixed the board addition can be merged :)

@PBrunot
Copy link
Contributor Author

PBrunot commented Aug 26, 2023

Thanks, I've implemented your comments.

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Resolution: Awaiting response labels Aug 28, 2023
@PBrunot PBrunot force-pushed the feature-lilygo-tdisplay branch from 34527fc to e08332e Compare August 28, 2023 16:19
@me-no-dev me-no-dev merged commit 13772ad into espressif:master Aug 29, 2023
@PBrunot PBrunot deleted the feature-lilygo-tdisplay branch August 29, 2023 12:16
@SuGlider
Copy link
Collaborator

SuGlider commented Sep 1, 2023

Attention::: WRONG FILE NAME ---> pins_arduino.h.txt

I'll fix it in the GPIO48 PR.

@PBrunot
Copy link
Contributor Author

PBrunot commented Sep 1, 2023

Sorry about that & thank you for your fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.
Projects
Development

Successfully merging this pull request may close these issues.

6 participants