Skip to content

Added support for the Aventen S3 Sync #8587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 31, 2023
Merged

Added support for the Aventen S3 Sync #8587

merged 2 commits into from
Aug 31, 2023

Conversation

avencan
Copy link
Contributor

@avencan avencan commented Aug 30, 2023

Description of Change

Addition of Aventen S3 Sync

Tests scenarios

NA

@avencan
Copy link
Contributor Author

avencan commented Aug 30, 2023

@P-R-O-C-H-Y I hope it all works now :)?

Also, I have a question, I have tested it and it seems it has an longer upload time than other board variants?

Thanks

@P-R-O-C-H-Y P-R-O-C-H-Y added this to the 2.0.12 milestone Aug 30, 2023
P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now :) LGTM

@P-R-O-C-H-Y
Copy link
Member

@P-R-O-C-H-Y I hope it all works now :)?

Also, I have a question, I have tested it and it seems it has an longer upload time than other board variants?

Thanks

I guess it have to be related to the flash size. I don't see any reason to take longer time than in other variants.

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. labels Aug 30, 2023
lucasssvaz
lucasssvaz requested changes Aug 30, 2023
View reviewed changes
@avencan avencan requested a review from lucasssvaz August 31, 2023 02:44
@avencan
Copy link
Contributor Author

avencan commented Aug 31, 2023

@lucasssvaz I hope the new commit fixes that

@me-no-dev me-no-dev merged commit dafff71 into espressif:master Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

@lucasssvaz lucasssvaz Awaiting requested review from lucasssvaz

Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
2.0.12
Development

Successfully merging this pull request may close these issues.
4 participants
@avencan @P-R-O-C-H-Y @lucasssvaz @me-no-dev