Skip to content

GPIO - make pin mode output_open_drain state readable #8592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2023
Merged

GPIO - make pin mode output_open_drain state readable #8592

merged 1 commit into from
Sep 1, 2023

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

Changed gpio OUTPUT_OPEN_DRAIN mode to act as input/output the same way, it have been changed for OUTPUT mode to have pin state readable by digitalRead()

Tests scenarios

Tested just on esp32s3, should not have any impact.

Related links

Close #8590
Close #7022

@P-R-O-C-H-Y P-R-O-C-H-Y added the Area: Peripherals API Relates to peripheral's APIs. label Sep 1, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y added this to the 2.0.12 milestone Sep 1, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Sep 1, 2023
@me-no-dev me-no-dev merged commit c7c975f into espressif:master Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev Awaiting requested review from me-no-dev

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Area: Peripherals API Relates to peripheral's APIs.
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
2.0.12
Development

Successfully merging this pull request may close these issues.

Incorrect value for OUTPUT_OPEN_DRAIN in esp32-hal-gpio.h Input Output with opend drain support
2 participants
@P-R-O-C-H-Y @me-no-dev