Fix pin attachInterrupt(digitalPinToInterrupt(48)) on all S3 based SOCs #8600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
VojtechBartoska
changed the title
VojtechBartoska
changed the title
P-R-O-C-H-Y
reviewed
Sep 5, 2023
| @@ -14,7 +14,7 @@ | |||
| #define NUM_ANALOG_INPUTS 12 | |||
|
|
|||
| #define analogInputToDigitalPin(p) (((p)<20)?(analogChannelToDigitalPin(p)):-1) | |||
| #define digitalPinToInterrupt(p) (((p)<48)?(p):-1) | |||
| #define digitalPinToInterrupt(p) (((p)<49)?(p):-1) | |||
There was a problem hiding this comment.
@SuGlider Bee Motion boards is based on ESP32-S2.
| @@ -14,7 +14,7 @@ | |||
| #define NUM_ANALOG_INPUTS 20 | |||
|
|
|||
| #define analogInputToDigitalPin(p) (((p)<20)?(analogChannelToDigitalPin(p)):-1) | |||
| #define digitalPinToInterrupt(p) (((p)<48)?(p):-1) | |||
| #define digitalPinToInterrupt(p) (((p)<49)?(p):-1) | |||
There was a problem hiding this comment.
@SuGlider This boards is based on ESP32S2
| @@ -15,7 +15,7 @@ | |||
| #define NUM_ANALOG_INPUTS 20 | |||
|
|
|||
| #define analogInputToDigitalPin(p) (((p)<20)?(analogChannelToDigitalPin(p)):-1) | |||
| #define digitalPinToInterrupt(p) (((p)<48)?(p):-1) | |||
| #define digitalPinToInterrupt(p) (((p)<49)?(p):-1) | |||
There was a problem hiding this comment.
@SuGlider This boards is based on ESP32S2
This was referenced Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes an issue with
attachInterrupt(digitalPinToInterrupt(48))that prevented it from setting GPIO48 as Interruptable.Tests scenarios
Only using ESP32-S3, as described in #8560
Related links
Fix #8560