CI: Add peripheral manager test #8811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasssvaz
added
Type: CI & Testing
|
@SuGlider Feel free to use this to test the RMT bug. |
lucasssvaz
force-pushed
the
ci/periman_test
branch
from
86fd9bb to
7bec446
Compare
lucasssvaz
force-pushed
the
ci/periman_test
branch
4 times, most recently
from
d119085 to
9c37020
Compare
lucasssvaz
force-pushed
the
ci/periman_test
branch
from
f94d8ec to
0b1616e
Compare
lucasssvaz
force-pushed
the
ci/periman_test
branch
2 times, most recently
from
1268669 to
8208a5c
Compare
lucasssvaz
force-pushed
the
ci/periman_test
branch
from
8208a5c to
63d8912
Compare
lucasssvaz
removed
the
3.0 migration
P-R-O-C-H-Y
approved these changes
Dec 6, 2023
Comment on lines
+72
to
+73
| pinMode(uart1_rx_pin, INPUT_PULLUP); | ||
| pinMode(uart1_tx_pin, OUTPUT); |
There was a problem hiding this comment.
Just a comment, we should commit the gpio_reset_pin to not need this. As its always detaching peripheral for GPIO and then using the UART.
P-R-O-C-H-Y
added
Status: Pending Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR aims to implement a test for the peripheral manager on the CI.
Tests scenarios
Tested locally with all DevKits.