Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename variants/heltec_wifi_kit_32_V3 to match entry in boards.txt. #8886

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Rename variants/heltec_wifi_kit_32_V3 to match entry in boards.txt. #8886

merged 1 commit into from
Nov 17, 2023

Conversation

audiophyl
Copy link

Description of Change

Rename the variant folder for heltec_wifi_kit_32_V3 board to match the contents of boards.txt

Tests scenarios

I have tested my Pull Request on Arduino-esp32 core v2.0.14 with the heltec_wifi_kit_32_V3 board.

Related links

N/A

@me-no-dev
Copy link
Member

@P-R-O-C-H-Y PTAL

P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for fixing that.

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Nov 15, 2023
@P-R-O-C-H-Y
Copy link
Member

@me-no-dev The PR is targeting 2.X branch, but it needs to be fixed in master too.

@me-no-dev
Copy link
Member

@audiophyl will you submit another PR for master branch? This one will not get merged there

@audiophyl
Copy link
Author

This typo doesn't exist in master. I'm only aware of it as a result of installing 2.0.14 in Arduino IDE, and it seems this only impacts 2.x releases.

@P-R-O-C-H-Y
Copy link
Member

P-R-O-C-H-Y commented Nov 15, 2023 •
edited
Loading

@audiophyl Yes you are right. I probably didn't checkout the master branch properly. My bad.
@me-no-dev So no need to fix in master. This can be merged.

@me-no-dev me-no-dev merged commit b435bf1 into espressif:release/v2.x Nov 17, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@audiophyl @me-no-dev @P-R-O-C-H-Y