Update RMT initialization code #8927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Commented out setting interrupt priority for both TX and RX configurations in the RMT initialization code.
|
|
|
and you break it for anyone on 5.1.2. Proper fix would be to check the ESP-IDF version |
|
why should be an outdated IDF version be supported? |
|
Cool. |
|
@diplfranzhoepfinger - I changed your PR to include the IDF 5.1.x version check... |
|
It could be useful when using Arduino as IDF component with any IDF 5.1.x version. |
|
Cool done. |
lucasssvaz
approved these changes
Nov 28, 2023
P-R-O-C-H-Y
approved these changes
Nov 28, 2023
P-R-O-C-H-Y
added
Status: Pending Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise we get an Compile Error with esp-idf 5.1.1