Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation when NO_GLOBAL_SERIAL is defined. #8933

Merged
merged 1 commit into from Nov 29, 2023
Merged

Fix compilation when NO_GLOBAL_SERIAL is defined. #8933

merged 1 commit into from Nov 29, 2023

Conversation

everslick
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 28, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@SuGlider SuGlider self-assigned this Nov 29, 2023
@SuGlider SuGlider self-requested a review November 29, 2023 03:50
@SuGlider SuGlider added this to the 3.0.0-Aplha3 milestone Nov 29, 2023
@SuGlider
Copy link
Collaborator

Thanks @everslick !

@SuGlider SuGlider added the Status: Pending Merge Pull Request is ready to be merged label Nov 29, 2023
SuGlider
SuGlider approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@me-no-dev me-no-dev merged commit 57e8e50 into espressif:master Nov 29, 2023
52 checks passed
@everslick everslick deleted the patch-1 branch November 29, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuGlider SuGlider SuGlider approved these changes

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees

@SuGlider SuGlider

Labels
Peripheral: UART Status: Pending Merge Pull Request is ready to be merged
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
3.0.0-Aplha3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@everslick @CLAassistant @SuGlider @P-R-O-C-H-Y @me-no-dev