Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add board revisions V1/V2/V3 to Heltec Wireless Stick #9205

Merged
merged 13 commits into from Feb 14, 2024
Merged

feat: Add board revisions V1/V2/V3 to Heltec Wireless Stick #9205

merged 13 commits into from Feb 14, 2024

Conversation

matthias-bs
Copy link
Contributor

@matthias-bs matthias-bs commented Feb 2, 2024

Checklist

  1. [ x] Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. [ x] Please check Contributing guide
  5. [ x] Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

Description of Change

Added two board revisions to Heltec Wireless Stick. Both revisions differ only in the on-board LoRa Transceiver: V2 - SX1276 / V3: SX1262. The modification allows to select the matching driver code according to the define selected with the board revision.

Tests scenarios

Tested with Arduino IDE V2.2.1.

#elif defined(ARDUINO_heltec_wireless_stick_v2)
    #pragma message("ARDUINO_heltec_wireless_stick_v2 defined; using on-board transceiver SX1276")
    #define USE_SX1276 // Heltec Wireless Stick V2

#elif defined(ARDUINO_heltec_wireless_stick_v3)
    #pragma message("ARDUINO_heltec_wireless_stick_v3 defined; using on-board transceiver SX1262")
    #define USE_SX1262 // Heltec Wireless Stick V3

The pragma message showed that the desired code section was selected.

Related links

@CLAassistant
Copy link

CLAassistant commented Feb 2, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Added HELTEC_WIRELESS_STICK_V1":
    • summary looks empty
    • type/action looks empty
  • the commit message "Added according to https://docs.heltec.cn/en/node/esp32/hardware_update_log.html#v2":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fixed partition scheme":
    • summary looks empty
    • type/action looks empty
  • the commit message "Renamed":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update boards.txt":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️ Please consider squashing your 13 commits (simplifying branch history).

👋 Hello matthias-bs, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 4bcd33b

boards.txt Show resolved Hide resolved
boards.txt Show resolved Hide resolved
boards.txt Show resolved Hide resolved
@P-R-O-C-H-Y
Copy link
Member

P-R-O-C-H-Y commented Feb 5, 2024

@matthias-bs would be also good to have the V1 added to the revisions.
Let me know when all fixes are done.

@matthias-bs
Copy link
Contributor Author

@matthias-bs would be also good to have the V1 added to the revisions. Let me know when all fixes are done.

This is going to be more complicated, because of a different pinning according to https://docs.heltec.cn/en/node/esp32/hardware_update_log.html, but I'll do this.

@matthias-bs matthias-bs changed the title feat: Add board revisions V2/V3 to Heltec Wireless Stick feat: Add board revisions V1/V2/V3 to Heltec Wireless Stick Feb 5, 2024
@matthias-bs
Copy link
Contributor Author

@P-R-O-C-H-Y I'm done now. I'd like to squash those commits and fix the messages according to the rules, but I don't know how to do this.

@lucasssvaz lucasssvaz added the Status: Review needed Issue or PR is awaiting review label Feb 7, 2024
boards.txt Show resolved Hide resolved
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthias-bs PTAL.

boards.txt Show resolved Hide resolved
@P-R-O-C-H-Y P-R-O-C-H-Y added Resolution: Awaiting response Waiting for response of author and removed Status: Review needed Issue or PR is awaiting review labels Feb 13, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Resolution: Awaiting response Waiting for response of author labels Feb 13, 2024
@me-no-dev me-no-dev merged commit 3de1d5b into espressif:master Feb 14, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants