Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed "Invalid mbox" error in SimpleTime example #9262

Merged
merged 4 commits into from Feb 21, 2024

Conversation

kinoh
Copy link
Contributor

@kinoh kinoh commented Feb 17, 2024

Description of Change

As stated in #8661, we have to call WiFi.mode before networking.

Tests scenarios

I've tested my Pull Request on arduino-esp32 v2.0.14 with ESP32-DevKitC-32E Board.

Related links

@CLAassistant
Copy link

CLAassistant commented Feb 17, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Feb 17, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "fix: changes the code to actually connect to the WiFi in roder to get time and date":
    • summary appears to be too long
  • the commit message "fix: removing call to WiFi.begin() at the end of the sketch. It must be called at first.":
    • summary appears to be too long
    • summary should not end with a period (full stop)

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

Messages
📖 You might consider squashing your 4 commits (simplifying branch history).

👋 Hello kinoh, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 835d7fa

@SuGlider
Copy link
Collaborator

@kinoh - Thanks for the PR! Indeed it is necessary to connect to the network in order to get the time/date information.
WiFi.mode() avoids it from crashing, but it doesn't make it work.
WiFi.begin() will avoid the error and also make it work.

@SuGlider SuGlider self-assigned this Feb 17, 2024
@SuGlider SuGlider added Type: Bug 🐛 All bugs Area: BT&Wifi BT & Wifi related issues Status: Review needed Issue or PR is awaiting review labels Feb 17, 2024
@SuGlider SuGlider added this to the 3.0.0-RC1 milestone Feb 17, 2024
@SuGlider
Copy link
Collaborator

@me-no-dev - This should also be merged to the release/v2.x branch.

@P-R-O-C-H-Y
Copy link
Member

P-R-O-C-H-Y commented Feb 19, 2024

@SuGlider is it ok now to call Wifi.begin() twice in the example?

@SuGlider
Copy link
Collaborator

@SuGlider is it ok now to call Wifi.begin() twice in the example?

You are right, it is also called latter. I must call it at first and then use IDF calls.

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Feb 19, 2024
@me-no-dev me-no-dev merged commit 72f9fe3 into espressif:master Feb 21, 2024
39 checks passed
@vortigont
Copy link
Contributor

Does mentioned issue (invalid mbox) really affects this ntp example? It is related to TCP socket, but NTP does not use TCP at all.
What this change is definitely breaks is NTPoDHCP feature, because dhcp client option should be set before acquiring IP address as stated in comment below.

/**
* NTP server address could be acquired via DHCP,
*
* NOTE: This call should be made BEFORE esp32 acquires IP address via DHCP,
* otherwise SNTP option 42 would be rejected by default.
* NOTE: configTime() function call if made AFTER DHCP-client run
* will OVERRIDE acquired NTP server address
*/
esp_sntp_servermode_dhcp(1); // (optional)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: BT&Wifi BT & Wifi related issues Status: Pending Merge Pull Request is ready to be merged Type: Bug 🐛 All bugs
Projects
Development

Successfully merging this pull request may close these issues.

None yet

7 participants