Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WT32-SC01 PLUS support #9284

Merged
merged 5 commits into from Feb 27, 2024
Merged

Add WT32-SC01 PLUS support #9284

merged 5 commits into from Feb 27, 2024

Conversation

c4801725870
Copy link
Contributor

@c4801725870 c4801725870 commented Feb 24, 2024


Description of Change

Added pins_arduino.h and a boilerplate boards.txt entry for the Panlee WT32-SC01 Plus.

Tests scenarios

Test on my WT32-SC01 Plus.

Related links

Please provide links to related issue, PRs etc.
https://www.marutsu.co.jp/contents/shop/marutsu/datasheet/khe_WT32-SC01-PLUS.pdf

Summary

Added pins_arduino.h and a boilerplate boards.txt entry for the Panlee WT32-SC01 Plus.

Added pins_arduino.h and a boilerplate boards.txt entry for the Panlee WT32-SC01 Plus.
@CLAassistant
Copy link

CLAassistant commented Feb 24, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Feb 24, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "ADD(tinyuf2 things): Added tinyuf2 bins":
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .
    • summary looks too short
    • type/action should start with a lowercase letter
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]
  • the commit message "Update pins_arduino.h":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update variants/wt32-sc01-plus/pins_arduino.h":
    • summary looks empty
    • type/action looks empty
  • the commit message "WT32-SC01 PLUS support":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

Messages
📖 You might consider squashing your 5 commits (simplifying branch history).

👋 Hello c4801725870, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 3758574

Edited the name to correctly reflect WT32-SC01 PLUS
@c4801725870 c4801725870 changed the title WT32-SC01 PLUS support Add WT32-SC01 PLUS support Feb 24, 2024
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wt32-sc01-plus.menu.PartitionScheme.tinyuf2=TinyUF2 Compatibility (2MB APP/3.7MB FFAT)
wt32-sc01-plus.menu.PartitionScheme.tinyuf2.build.custom_bootloader=bootloader_tinyuf2
wt32-sc01-plus.menu.PartitionScheme.tinyuf2.build.custom_partitions=partitions_tinyuf2
wt32-sc01-plus.menu.PartitionScheme.tinyuf2.upload.extra_flags=0x410000 "{runtime.platform.path}/variants/{build.variant}/tinyuf2.bin"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing the tinyuf2.bin file in the variant folder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing the tinyuf2.bin file in the variant folder.

Sorry I updated it. Also I am not sure how to squash commits, sorry about that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. No need to squash commits ;)

variants/wt32-sc01-plus/pins_arduino.h Outdated Show resolved Hide resolved
c4801725870 and others added 2 commits February 26, 2024 17:16
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
ADD(tinyuf2 things): Added tinyuf2 bins
@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Feb 27, 2024
@me-no-dev me-no-dev merged commit e3748c1 into espressif:master Feb 27, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants