Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add board definition for Wemos C3 Pico V1.0.0 - Lolin #9442

Merged
merged 5 commits into from Apr 2, 2024

Conversation

lboue
Copy link
Contributor

@lboue lboue commented Apr 1, 2024

Add board definition for Wemos C3 Pico V1.0.0 - Lolin

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide
  5. Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

This entire section above can be deleted if all items are checked.


Description of Change

Add board definition for Wemos C3 Pico V1.0.0 - Lolin

Tests scenarios

Please describe on what Hardware and Software combinations you have tested this Pull Request and how.

(eg. I have tested my Pull Request on Arduino-esp32 core v2.0.2 with ESP32 and ESP32-S2 Board with this scenario)

Related links

No related issue, PRs.

(eg. Closes #number of issue)

Copy link
Contributor

github-actions bot commented Apr 1, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Add board definition for Wemos C3 Pico V1.0.0 - Lolin (9442)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add board definition for Wemos C3 Pico V1.0.0 - Lolin":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update boards.txt":
    • summary looks empty
    • type/action looks empty
  • the commit message "Wemos C3 Pico V1.0.0 - Lolin: Add SS pin to fix CI build":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

Messages
📖 You might consider squashing your 5 commits (simplifying branch history).

👋 Hello lboue, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 39d5110

@lucasssvaz
Copy link
Collaborator

You also need to add your board to board.txt

* feat(esp32): Add board definition for Wemos C3 Pico to boards.txt
@lboue
Copy link
Contributor Author

lboue commented Apr 1, 2024

You also need to add your board to board.txt

@lucasssvaz
I just added it with commit 115dd17.

Wemos C3 Pico V1.0.0 - Lolin: Add SS pin to fix CI build
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lboue Only one small change needed :)

boards.txt Show resolved Hide resolved
@lboue
Copy link
Contributor Author

lboue commented Apr 2, 2024

@lboue Only one small change needed :)

Thanks for pointing this. Fixed with 39d5110.

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Apr 2, 2024
@me-no-dev me-no-dev merged commit 0523b94 into espressif:master Apr 2, 2024
39 checks passed
@lboue lboue deleted the lolin_c3_pico_ branch April 2, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants