Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name to HWCDC_Events.ino (From HWSerial_Events.ino) #9483

Merged
merged 8 commits into from Apr 11, 2024

Conversation

SuGlider
Copy link
Collaborator

@SuGlider SuGlider commented Apr 11, 2024

Description of Change

Changes the name of the example sketch to the correct HWCDC instead of HWSerial (UART).

Tests scenarios

Tested with C3 using the example. Using CDC on Boot enabled and disabled.
Tested with S2 and ESP32 for the error messages/warning.
Tested with S3 in OTG and HW CDC Serial USB modes.

Related links

None.

@SuGlider SuGlider added the Type: Example Issue is related to specific example. label Apr 11, 2024
@SuGlider SuGlider added this to the 3.0.0-RC1 milestone Apr 11, 2024
@SuGlider SuGlider self-assigned this Apr 11, 2024
Copy link
Contributor

github-actions bot commented Apr 11, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Create .skip.esp32":
    • summary looks empty
    • type/action looks empty
  • the commit message "Create .skip.esp32s2":
    • summary looks empty
    • type/action looks empty
  • the commit message "Create HWCDC_Events.ino":
    • summary looks empty
    • type/action looks empty
  • the commit message "Delete libraries/ESP32/examples/HWSerial_Events/.skip.esp32":
    • summary looks empty
    • type/action looks empty
  • the commit message "Delete libraries/ESP32/examples/HWSerial_Events/.skip.esp32s2":
    • summary looks empty
    • type/action looks empty
  • the commit message "Delete libraries/ESP32/examples/HWSerial_Events/HWSerial_Events.ino":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fixes CI for S3":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fixes HWCDC_Events.ino":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️ Please consider squashing your 8 commits (simplifying branch history).
⚠️

The source branch "SuGlider-patch-1" incorrect format:

  • contains uppercase letters. This can cause troubles on case-insensitive file systems (macOS).
    Please rename your branch.

👋 Hello SuGlider, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 38cba31

@SuGlider
Copy link
Collaborator Author

@me-no-dev - This is the same change you have requested in the 2.0.15 release... That was also in the 3.0.0.

@me-no-dev me-no-dev merged commit 04b70bb into master Apr 11, 2024
40 checks passed
@me-no-dev me-no-dev deleted the SuGlider-patch-1 branch April 11, 2024 15:19
P-R-O-C-H-Y pushed a commit to P-R-O-C-H-Y/arduino-esp32 that referenced this pull request Apr 16, 2024
…#9483)

* Create HWCDC_Events.ino

* Delete libraries/ESP32/examples/HWSerial_Events/.skip.esp32

* Delete libraries/ESP32/examples/HWSerial_Events/.skip.esp32s2

* Delete libraries/ESP32/examples/HWSerial_Events/HWSerial_Events.ino

* Create .skip.esp32

* Create .skip.esp32s2

* Fixes HWCDC_Events.ino

* Fixes CI for S3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Example Issue is related to specific example.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants