Skip to content

fix(ledc): Match channel number with groups #9638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2024
Merged

fix(ledc): Match channel number with groups #9638

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9664f4
fix(ledc): Match channel number with groups
P-R-O-C-H-Y May 15, 2024
5cd1b77
Merge branch 'master' into fix/ledc-attach-duty-check
P-R-O-C-H-Y May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cores/esp32/esp32-hal-ledc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ bool ledcAttachChannel(uint8_t pin, uint32_t freq, uint8_t resolution, uint8_t c
return false;
}

uint32_t duty = ledc_get_duty(group, channel);
uint32_t duty = ledc_get_duty(group, (channel % 8));

ledc_channel_config_t ledc_channel = {
.speed_mode = group, .channel = (channel % 8), .timer_sel = timer, .intr_type = LEDC_INTR_DISABLE, .gpio_num = pin, .duty = duty, .hpoint = 0
Expand Down