Clarify GPIO Mask Comment (IDFGH-8724) #10165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
|
Thanks for your contribution. |
|
sha=11a0aa548e14904bfef7caba6161bd80d5086480 |
espressif-bot
added
Status: In Progress
espressif-bot
added
Resolution: NA
espressif-bot
pushed a commit
that referenced
this pull request
Nov 18, 2022
|
commits are squashed in 0c89ab3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was confused by the comment in esp32/include/soc/soc_caps.h on SOC_GPIO_VALID_GPIO_MASK.
After verifying the mask bits are correct, I have updated the comments for esp32, esp32s2, esp32s3.
I did not check the mask base 0x...FF size.
Not touched because they use a different mask format: esp32c2, esp32c3, esp32c6, exp32h4.