This repository was archived by the owner on Oct 9, 2023. It is now read-only.
idfboot: Fallback to default values on failure to parse configs #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com>
gustavonihei
force-pushed
the
feature/idfboot_default_values
branch
from
cc04b9d to
109e4de
Compare
Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com>
gustavonihei
force-pushed
the
feature/idfboot_default_values
branch
from
109e4de to
bda015b
Compare
Ouss4
approved these changes
Oct 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to bring some minor improvements to the IDFboot bootloader build:
Instead of relying on the
gen_esp32part.pydefault values for missing parameters, we are now defining the default values on theidfboot.shscript. This makes the script a bit more intuitive. As a bonus, the shellCheck warning is now properly fixed.Define default values for SPI Flash parameters and Partition Table offset in the
sdkconfig.defaultsfile.