-
Notifications
You must be signed in to change notification settings - Fork 171
fix(esp_modem): run CI build job for all targets #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(esp_modem): run CI build job for all targets #242
Conversation
2cb6e99
to
3b537a3
Compare
3b537a3
to
0c9b51b
Compare
Also * removed IDFv4.1 from tests * added common build_apps.py utility for finding/building apps
Some targets don't support UART_SCLK_APB (e.g. esp32c2) This change is applicable only for IDFv5.0 and later, as older version didn't define UART_SCLK_DEFAULT. Closes espressif#241
0c9b51b
to
e6beccb
Compare
e6beccb
to
cbda157
Compare
9a1c8ac
to
fd8eda8
Compare
fd8eda8
to
1bea39a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question regarding full test set running. Do we need such label also?
LGTM!
|
Thanks for the review, both points make sense -- will address, thanks!
good point, will add support for this new label to run everything.
ATM it would check the modification paths to run only relevant tests. But I agree that we should check all components after merge to keep |
1bea39a
to
13eca12
Compare
I've decided not to implement one common label, since it would unnecessarily complicate the conditions (and would need to apply it everywhere). we can always add it in future if needed. for now, I don't think we'd have too many PRs affecting multiple components and if so, we can add more labels. - if: contains(github.event.pull_request.labels.*.name, 'mdns')
+ if: $${ contains(github.event.pull_request.labels.*.name, 'mdns') && contains(github.event.pull_request.labels.*.name, 'run_all') }}
Done. |
Regression from a089e0d Merged as espressif#242
Simplified the workflow, use
idf-build-apps
package to find apps for all supported targets.Additional changes:
<component>__<test_type>.yml
-- component related test workflow (need the component label to run it in PR)common_check.yml
-- runs unconditionallyFuture changes:
build_apps.py
for all targetsupload_artifact
job usingci/clean_build_artifacts.sh
(as done inesp_modem
target tests)