fix(cli): Don't require token for dry-run of version upload

CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- Don't require token for `--dry-run` of `compote component upload` command
 - Fix incorrect message suggestion to check upload status if non-default profile is used
 
 ## [1.3.2] - 2023-07-05

idf_component_manager/core.py

@@ -485,7 +485,13 @@ def upload_component(
         dry_run=False,  # type: bool
         dest_dir=None,
     ):  # type: (...) -> None
-        client, namespace = service_details(namespace, service_profile)
+        """
+        Uploads a component version to the registry.
+        """
+        token_required = not (check_only or dry_run)
+        client, namespace = service_details(
+            namespace, service_profile, token_required=token_required
+        )
 
         if archive:
             if not os.path.isfile(archive):
@@ -538,10 +544,12 @@ def upload_component(
 
         # Uploading/validating the component
         info_message = 'Uploading' if not dry_run else 'Validating'
-        print_info('%s archive %s' % (info_message, archive))
-        job_id = client.upload_version(
-            component_name=component_name, file_path=archive, validate_only=dry_run
-        )
+        print_info('{} archive {}'.format(info_message, archive))
+
+        if dry_run:
+            job_id = client.validate_version(file_path=archive)
+        else:
+            job_id = client.upload_version(component_name=component_name, file_path=archive)
 
         # Wait for processing
         profile_text = (

idf_component_tools/api_client.py

@@ -474,9 +474,7 @@ def component(self, request, component_name, version=None):
             examples=examples,
         )
 
-    @auth_required
-    @_request(cache=False)
-    def upload_version(self, request, component_name, file_path, validate_only=False):
+    def _upload_version_to_endpoint(self, request, file_path, endpoint):
         with open(file_path, 'rb') as file:
             filename = os.path.basename(file_path)
 
@@ -493,11 +491,6 @@ def callback(
 
             data = MultipartEncoderMonitor(encoder, callback)
 
-            if validate_only:
-                endpoint = ['components', 'validate']
-            else:
-                endpoint = ['components', component_name.lower(), 'versions']
-
             try:
                 return request(
                     'post',
@@ -509,6 +502,17 @@ def callback(
             finally:
                 progress_bar.close()
 
+    @auth_required
+    @_request(cache=False)
+    def upload_version(self, request, component_name, file_path):
+        return self._upload_version_to_endpoint(
+            request, file_path, ['components', component_name.lower(), 'versions']
+        )
+
+    @_request(cache=False)
+    def validate_version(self, request, file_path):
+        return self._upload_version_to_endpoint(request, file_path, ['components', 'validate'])
+
     @auth_required
     @_request(cache=False)
     def delete_version(self, request, component_name, component_version):

tests/conftest.py

@@ -141,8 +141,12 @@ def example_component_path(fixtures_path):
 
 
 @pytest.fixture()
-def mock_registry(monkeypatch):
+def mock_registry_without_token(monkeypatch):
     monkeypatch.setenv('IDF_COMPONENT_REGISTRY_URL', 'http://localhost:5000')
+
+
+@pytest.fixture()
+def mock_registry(mock_registry_without_token, monkeypatch):
     monkeypatch.setenv('IDF_COMPONENT_API_TOKEN', 'test')
 
 

tests/test_component_manager.py

@@ -126,7 +126,7 @@ def test_allow_existing_component(mock_registry, release_component_path, tmp_pat
 
 
 @vcr.use_cassette('tests/fixtures/vcr_cassettes/test_validate_component.yaml')
-def test_validate_component(mock_registry, pre_release_component_path):
+def test_validate_component(mock_registry_without_token, pre_release_component_path):
     manager = ComponentManager(path=pre_release_component_path)
 
     manager.upload_component(