[Gadgbetbridge] Malformed JSON toast on updating apps

[halemmerich]

Affected hardware version

Bangle 2

Your firmware version

2v16.7

The bug

Every app update using GadgetBridge creates a toast message with this content:
"Malformed JSON from Bangle.js: No value for t". This is only a cosmetic problem, updates work fine otherwise.

It seems this is caused by GadgetBridge reading the app info file and getting a JSON-parseable Object back. This is then parsed as a GadgetBridge message and has no type key.

01-10 12:35:16.178  8237  8249 I nodomain.freeyourgadget.gadgetbridge.service.devices.banglejs.BangleJSDeviceSupport: UART RX LINE: {"id":"health","name":"Health","src":"health.app.js","icon":"health.img","version":"0.19","tags":"tool,system,health","files":"health.info,health.app.js,health.img,health.boot.js,health,}
01-10 12:35:16.182  8237  8249 I nodomain.freeyourgadget.gadgetbridge.service.devices.banglejs.BangleJSDeviceSupport: UART RX JSON parsed successfully
01-10 12:35:16.182  8237  8249 I nodomain.freeyourgadget.gadgetbridge.service.devices.banglejs.BangleJSDeviceSupport: UART RX JSON parse failure: No value for t
01-10 12:35:16.183  8237  8249 E nodomain.freeyourgadget.gadgetbridge.util.GB: Malformed JSON from Bangle.js: No value for t
01-10 12:35:16.191  8237  8237 I nodomain.freeyourgadget.gadgetbridge.devices.banglejs.AppsManagementActivity: WebView TX: .json"}

Installed apps

No response

[gfwilliams]

Ok, thanks. I guess we could just ignore the JSON in Gadgetbridge if there's no 't' in it then (maybe just log it rather than a toast)

[gfwilliams]

Fixed with https://codeberg.org/Freeyourgadget/Gadgetbridge/commit/b16464b3b69f8bffae0e4db5f986e17a29ea4fb4