android - Use course from GB if available #2504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I guess either way it won't break anything for this to be in - I'll tweak it to !isFinite though as I think that reads better :) |
schklom
referenced
this pull request
in schklom/Gadgetbridge-osm
Mar 24, 2023
This tries to use bearing and number of satellites if available. ~~Bangle.js watch currently sets course=NaN in it's implementation of the GPS event handler, so to be of use this needs a small change there as well: [https://github.com/espruino/BangleApps/pull/2504](https://github.com/espruino/BangleApps/pull/2504)~~ Change has been merged. Please advise on needed changes or oversights, thanks :) Co-authored-by: Martin Boonk <martin@boonk.info> Reviewed-on: https://codeberg.org/Freeyourgadget/Gadgetbridge/pulls/3026 Co-authored-by: halemmerich <halemmerich@noreply.codeberg.org> Co-committed-by: halemmerich <halemmerich@noreply.codeberg.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of https://codeberg.org/Freeyourgadget/Gadgetbridge/pulls/3026. Will mark this as ready when that PR is merged.