Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #129: Drop XML Config support #137

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Issue #129: Drop XML Config support #137

merged 1 commit into from
Mar 11, 2020

Conversation

gadunga
Copy link
Collaborator

@gadunga gadunga commented Feb 29, 2020

I can't make an actual 1.0 branch, but here's a PR for removing XML configs.

Edit: closes #129

@estk estk added this to the 1.0 milestone Mar 9, 2020
@estk
Copy link
Owner

estk commented Mar 9, 2020

This is perfect, I'll get a devel branch going when I'm done with my cleanup pr and we can point the target of this there.

@estk estk added blocked Blocked by an external dependency waiting Waiting on internal work for merge and removed blocked Blocked by an external dependency waiting Waiting on internal work for merge labels Mar 9, 2020
@estk estk changed the base branch from master to devel March 10, 2020 18:27
@gadunga
Copy link
Collaborator Author

gadunga commented Mar 11, 2020

Rebased, but I'll wait on the other one first.

@gadunga
Copy link
Collaborator Author

gadunga commented Mar 11, 2020

Done.

@estk estk merged commit 1300965 into estk:devel Mar 11, 2020
@estk estk mentioned this pull request Mar 11, 2020
estk pushed a commit that referenced this pull request Mar 11, 2020
estk pushed a commit that referenced this pull request Jul 22, 2020
estk added a commit that referenced this pull request Dec 16, 2020
* Expose errors as failure::Error (#138)

* Issue #129: Drop XML Config support (#137)

* Rename file feature (#147)

* Rename to config_parsing

* Add workflows for devel

* Update changelog

* Add an init function which takes a RawConfig (#150)

* Clippy

* Changelog, cleanup

* json macro

* qualify

* typo

* Remove unused dir from .gitignore

* Init raw on all platforms

* Remove log4rs::FormatError::XmlFeatureFlagRequired (#156)

* Expand env vars in the path for File and RollingFile appenders (#155)

* Reorganize config (#157)

* Reorganize config

* allow missing docs so tests run

* lint abatement

* some renames

* Use anyhow/thiserror (#159)

* Use anyhow/thiserror

* Change addtivity to additive to match the actual code (#163)

* Errors 1.0 (#160)

Co-authored-by: shmapdy <richard.meester@gmail.com>

* clippy

* Standard derives rebase (#175)

* Bump serde-value

* Alpha 1 version

* Update highlight colors to be the same as env_logger (#167)

* Custom err handler (#183)

* WIP custom err handling

* Compiling

* Add an  method to the public api

* re-enable Debug

* bump ver

* fix: init_raw_config forcing max_log_level to Info (#200)

Co-authored-by: braindead <braindeaded@protonmail.com>

* pattern encoder: Set trace to default color, reset formatting after (#186)

* pattern encoder: Set trace to default color, reset formatting after

* Fix formatting of last commit

* lol apparently rustfmt doesn't like commas? idk if this will work

* Set trace color to cyan

Co-authored-by: Richard M <gadunga@users.noreply.github.com>
Co-authored-by: shmapdy <richard.meester@gmail.com>
Co-authored-by: Charles Giguere <IceSentry@users.noreply.github.com>
Co-authored-by: 1c7718e7 <shirokovMartin@gmail.com>
Co-authored-by: braindead <braindeaded@protonmail.com>
Co-authored-by: Julia DeMille <8127111+judemille@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop XML config support
2 participants