Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop XML config support #129

Closed
estk opened this issue Feb 21, 2020 · 1 comment · Fixed by #137
Closed

Drop XML config support #129

estk opened this issue Feb 21, 2020 · 1 comment · Fixed by #137
Labels
open pr An open PR exists
Milestone
1.0

Comments

@estk
Copy link
Owner

estk commented Feb 21, 2020

I've never seen anyone using xml config for a rust project config. I'd like to drop support. We can deprecate the use to start.
@estk estk added this to the 1.0 milestone Feb 21, 2020
@estk estk removed the 1.0 label Feb 21, 2020
gadunga added a commit to gadunga/log4rs that referenced this issue Feb 29, 2020
@gadunga
Issue estk#129: Drop XML Config support
70249a7
gadunga added a commit to gadunga/log4rs that referenced this issue Feb 29, 2020
@gadunga
Issue estk#129: Drop XML Config support
d51d93d
@estk estk added open pr An open PR exists and removed good first issue help wanted labels Mar 9, 2020
@gadunga gadunga mentioned this issue Mar 9, 2020
Merged
gadunga added a commit to gadunga/log4rs that referenced this issue Mar 11, 2020
@gadunga
Issue estk#129: Drop XML Config support
0bd4db7
gadunga added a commit to gadunga/log4rs that referenced this issue Mar 11, 2020
@gadunga
Issue estk#129: Drop XML Config support
27a5c88
estk pushed a commit that referenced this issue Mar 11, 2020
@gadunga
Issue #129: Drop XML Config support (#137)
1300965
@estk
Copy link
Owner Author

estk commented Mar 11, 2020

Closed by #137

@estk estk closed this as completed Mar 11, 2020
estk pushed a commit that referenced this issue Mar 11, 2020
@gadunga @estk
Issue #129: Drop XML Config support (#137)
67c077b
estk pushed a commit that referenced this issue Jul 22, 2020
@gadunga @estk
Issue #129: Drop XML Config support (#137)
905183e
estk added a commit that referenced this issue Dec 16, 2020
@estk @gadunga
@IceSentry @1c7718e7 @braindead @judemille
1.0 Release (#154)
d637eea 
* Expose errors as failure::Error (#138)

* Issue #129: Drop XML Config support (#137)

* Rename file feature (#147)

* Rename to config_parsing

* Add workflows for devel

* Update changelog

* Add an init function which takes a RawConfig (#150)

* Clippy

* Changelog, cleanup

* json macro

* qualify

* typo

* Remove unused dir from .gitignore

* Init raw on all platforms

* Remove log4rs::FormatError::XmlFeatureFlagRequired (#156)

* Expand env vars in the path for File and RollingFile appenders (#155)

* Reorganize config (#157)

* Reorganize config

* allow missing docs so tests run

* lint abatement

* some renames

* Use anyhow/thiserror (#159)

* Use anyhow/thiserror

* Change addtivity to additive to match the actual code (#163)

* Errors 1.0 (#160)

Co-authored-by: shmapdy <richard.meester@gmail.com>

* clippy

* Standard derives rebase (#175)

* Bump serde-value

* Alpha 1 version

* Update highlight colors to be the same as env_logger (#167)

* Custom err handler (#183)

* WIP custom err handling

* Compiling

* Add an  method to the public api

* re-enable Debug

* bump ver

* fix: init_raw_config forcing max_log_level to Info (#200)

Co-authored-by: braindead <braindeaded@protonmail.com>

* pattern encoder: Set trace to default color, reset formatting after (#186)

* pattern encoder: Set trace to default color, reset formatting after

* Fix formatting of last commit

* lol apparently rustfmt doesn't like commas? idk if this will work

* Set trace color to cyan

Co-authored-by: Richard M <gadunga@users.noreply.github.com>
Co-authored-by: shmapdy <richard.meester@gmail.com>
Co-authored-by: Charles Giguere <IceSentry@users.noreply.github.com>
Co-authored-by: 1c7718e7 <shirokovMartin@gmail.com>
Co-authored-by: braindead <braindeaded@protonmail.com>
Co-authored-by: Julia DeMille <8127111+judemille@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
open pr An open PR exists
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Issue #129: Drop XML Config support gadunga/log4rs
1 participant
@estk