Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to expand env vars in the path for File and RollingFileAppenders #155

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

gadunga
Copy link
Collaborator

@gadunga gadunga commented Apr 4, 2020

No description provided.

@gadunga gadunga force-pushed the devel branch 3 times, most recently from 2e6d5fd to e238fb3 Compare April 4, 2020 23:01
@estk
Copy link
Owner

estk commented Apr 5, 2020

Looks great, excellent docs.
Would be good to add unit tests for the replacement code.

@gadunga
Copy link
Collaborator Author

gadunga commented Apr 5, 2020

Doh no problem, give me a few minutes and I'll push them up.

@gadunga
Copy link
Collaborator Author

gadunga commented Apr 5, 2020

Tests are pushed. Let me know if there's something I've missed.

@gadunga gadunga force-pushed the devel branch 2 times, most recently from 04804f2 to a128052 Compare April 5, 2020 17:29
@estk estk merged commit a7d00bc into estk:devel Apr 6, 2020
estk added a commit that referenced this pull request Dec 16, 2020
* Expose errors as failure::Error (#138)

* Issue #129: Drop XML Config support (#137)

* Rename file feature (#147)

* Rename to config_parsing

* Add workflows for devel

* Update changelog

* Add an init function which takes a RawConfig (#150)

* Clippy

* Changelog, cleanup

* json macro

* qualify

* typo

* Remove unused dir from .gitignore

* Init raw on all platforms

* Remove log4rs::FormatError::XmlFeatureFlagRequired (#156)

* Expand env vars in the path for File and RollingFile appenders (#155)

* Reorganize config (#157)

* Reorganize config

* allow missing docs so tests run

* lint abatement

* some renames

* Use anyhow/thiserror (#159)

* Use anyhow/thiserror

* Change addtivity to additive to match the actual code (#163)

* Errors 1.0 (#160)

Co-authored-by: shmapdy <richard.meester@gmail.com>

* clippy

* Standard derives rebase (#175)

* Bump serde-value

* Alpha 1 version

* Update highlight colors to be the same as env_logger (#167)

* Custom err handler (#183)

* WIP custom err handling

* Compiling

* Add an  method to the public api

* re-enable Debug

* bump ver

* fix: init_raw_config forcing max_log_level to Info (#200)

Co-authored-by: braindead <braindeaded@protonmail.com>

* pattern encoder: Set trace to default color, reset formatting after (#186)

* pattern encoder: Set trace to default color, reset formatting after

* Fix formatting of last commit

* lol apparently rustfmt doesn't like commas? idk if this will work

* Set trace color to cyan

Co-authored-by: Richard M <gadunga@users.noreply.github.com>
Co-authored-by: shmapdy <richard.meester@gmail.com>
Co-authored-by: Charles Giguere <IceSentry@users.noreply.github.com>
Co-authored-by: 1c7718e7 <shirokovMartin@gmail.com>
Co-authored-by: braindead <braindeaded@protonmail.com>
Co-authored-by: Julia DeMille <8127111+judemille@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants