Add an init function which takes a RawConfig #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sooo....what's up with CI/circleci? |
|
You should be all set, just need to add a commit to re-trigger a job. (I hadn't properly removed the circleci webhook, and they must have changed something so that if you dont have a config it fails now.) |
|
Alright, should be good to go. |
|
Okay, so everything is good to go, except one last thing... theres a TODO comment in the test, i think it might be better to open an issue and link the line. |
|
No problem. I'll update the the MR shortly. |
gadunga
force-pushed
the
devel
branch
2 times, most recently
from
4a74669
to
2296878
Compare
|
Alright, I fixed up the test so it does something meaningful. It'll init logging from a raw config, verify init was successful, write some stuff to the file and verify that the data was written to the file. |
estk
pushed a commit
that referenced
this pull request
Jul 22, 2020
estk
added a commit
that referenced
this pull request
Dec 16, 2020
* Expose errors as failure::Error (#138) * Issue #129: Drop XML Config support (#137) * Rename file feature (#147) * Rename to config_parsing * Add workflows for devel * Update changelog * Add an init function which takes a RawConfig (#150) * Clippy * Changelog, cleanup * json macro * qualify * typo * Remove unused dir from .gitignore * Init raw on all platforms * Remove log4rs::FormatError::XmlFeatureFlagRequired (#156) * Expand env vars in the path for File and RollingFile appenders (#155) * Reorganize config (#157) * Reorganize config * allow missing docs so tests run * lint abatement * some renames * Use anyhow/thiserror (#159) * Use anyhow/thiserror * Change addtivity to additive to match the actual code (#163) * Errors 1.0 (#160) Co-authored-by: shmapdy <richard.meester@gmail.com> * clippy * Standard derives rebase (#175) * Bump serde-value * Alpha 1 version * Update highlight colors to be the same as env_logger (#167) * Custom err handler (#183) * WIP custom err handling * Compiling * Add an method to the public api * re-enable Debug * bump ver * fix: init_raw_config forcing max_log_level to Info (#200) Co-authored-by: braindead <braindeaded@protonmail.com> * pattern encoder: Set trace to default color, reset formatting after (#186) * pattern encoder: Set trace to default color, reset formatting after * Fix formatting of last commit * lol apparently rustfmt doesn't like commas? idk if this will work * Set trace color to cyan Co-authored-by: Richard M <gadunga@users.noreply.github.com> Co-authored-by: shmapdy <richard.meester@gmail.com> Co-authored-by: Charles Giguere <IceSentry@users.noreply.github.com> Co-authored-by: 1c7718e7 <shirokovMartin@gmail.com> Co-authored-by: braindead <braindeaded@protonmail.com> Co-authored-by: Julia DeMille <8127111+judemille@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets try this again.