Rename n_bins to probes in genemetrics output
#586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The column `n_bins` in the genemetrics output means exactly the same thing as `probes` in regular CNS files. For compatibility, it is better if they are named the same. This would also allow feeding genemetrics CNS files to the call and export commands (see etal#585).
|
Note: in theory, |
|
This looks like a good solution, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #585. Thank you @eriktoo for reporting and investigating this.
The column
n_binsin the genemetrics output means exactly the same thing asprobesin regular CNS files. For compatibility, it is better if they are named the same. This would also allow feeding genemetrics CNS files to the call and export commands.