Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the region regex to allow NCBI-style chromosome names #603

Merged
merged 1 commit into from
May 5, 2021

Conversation

tskir
Copy link
Collaborator

@tskir tskir commented Apr 26, 2021

Closes #602.

The existing regex for the genomic range does not allow NCBI-style chromosome names, such as NC_039898.1.

After this update, it will still require that the chromosome name starts with an alphanumeric character; however, in subsequent characters dots are now allowed.

The existing regex for the genomic range does not allow NCBI-style
chromosome names, such as NC_039898.1.

After this update, it will still require that the chromosome name starts
with an alphanumeric character; however, in subsequent characters dots
are now allowed.
Copy link
Owner

@etal etal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subtle. LGTM. Thanks!

@etal etal merged commit 15d21cf into master May 5, 2021
@etal etal deleted the 602-chromosomes-with-dots branch May 5, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to 'scatter' plot region of chromosome name with punctuation marks
2 participants