This repository has been archived by the owner on May 2, 2024. It is now read-only.
Dynamic fields list #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use it for fields and errors, and implement remaining features in error handling for lists
amitaibu
reviewed
Oct 27, 2016
| @@ -65,7 +61,11 @@ textArea : Input e String | |||
| textArea state attrs = | |||
| let | |||
| formAttrs = | |||
| <<<<<<< HEAD | |||
| [ defaultValue (state.value ?= "") | |||
There was a problem hiding this comment.
thanks, not sure how that went through tests :D
amitaibu
reviewed
Oct 30, 2016
| [ class "row link" ] | ||
| [ col' 3 [ text "Link" ] | ||
| , Input.textInput | ||
| (Form.getFieldAsString ("links." ++ (toString i) ++ ".name") form) |
There was a problem hiding this comment.
The link input field's CSS seems to be missing.
| \_ -> | ||
| let | ||
| ( name, value ) = | ||
| ( "links.0.name", "Twitter" ) |
There was a problem hiding this comment.
wondering, what happens is the path is wrong?
There was a problem hiding this comment.
when wrongly indexed, the input will be ignored. it was adding too much complexity to deal with holes in a list :)
* flipped `andThen` * `apply` flipped and renamed to `andMap` * renamed: * `formN` to `mapN` * `get` to `field` * `formatError` to `mapError` * dissociated input types (`Form.InputType`) and input values (`Field.FieldValue`) so now `Field` API follows `Json.Encode` * means `Msg(Input)` and `Form.Input` helpers changed * tuples builders for initial fields moved to `Form.Init` module * misc 0.18 fixes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for dynamic list of fields, as requested in #50
This required a more powerful tree structure so its representation and handling have been extracted to a dedicated module. A few things have changed in the API, that will be a major release.
Field.FieldandError.Errorhave been renamed toField.FieldValueandError.ErrorValueFieldandErrorare now just trees of values and can be handled byTreemodule if needed.Error.valueFieldmodule are now producing tuplesAppendandRemovemessagessomeGroup.0.someField/cc @amitaibu @DavidHernandez