-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete migration to OWNERS file #16794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks!
We need the MAINTAINERS file for the CNCF. We're currently both a project and a SIG, and the CNCF needs us to have a MAINTAINERs file in this repo (as well as OWNERs), and only this repo. So leave that in place while updating OWNERs. |
Could you clarify this? Do you mean that we only need to keep the MAINTAINERS in this repo? In other words, we can remove MAINTAINERS files from all other repositories, e.g. bbolt/MAINTAINERS, raft/MAINTAINERS, etc.? |
That's correct. Only the one in this repo matters. |
OK, thx for the clarification. |
0bc62cd
to
97f33be
Compare
|
97f33be
to
0fd5109
Compare
@jberkus is right that we need a file that lists project "maintainers", but it doesn't necessarily requires a MAINTAINERS file. We can just change the file name mentioned in https://github.com/cncf/foundation/blob/main/project-maintainers.csv#L264-L269. In the file there are sigs that directly link to repo https://github.com/kubernetes/community To make the transition complete (not necessarily in this PR) we should remove the MAINTAINERS file and change https://github.com/cncf/foundation/blob/main/project-maintainers.csv#L264-L269 to link to https://github.com/kubernetes/community/tree/master/sig-etcd#leadership |
Thanks for the idea above @serathius. This pull request was discussed during the recent etcd triage meeting (08:24). We discussed a plan which is:
@etcd-io/maintainers-etcd can you please give a +1 on this comment or reply with either approval to proceed with this plan or any questions. Thanks! 🙏🏻 |
+1 Thanks all. |
+1 |
Gentle ping @wenjiaswe, @mitake, @ptabor, @spzala - please see the plan outlined in my comment above and provide a +1 or any questions so we can move forward with consensus. |
+1 thank you very much @jmhbnz ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 Thanks @jmhbnz
Signed-off-by: James Blair <mail@jamesblair.net>
0fd5109
to
aa67cbe
Compare
cncf/foundation#666 has now merged so we are good to merge this one now @serathius. |
As part of our setup for sig-etcd we intend to adopt the kubernetes project
OWNERS
file approach for managing repository and github org permissions automatically as code.In #16600 we introduced the
OWNERS
file for etcd.This pull request is a tidy-up to remove the old
MAINTAINERS
file approach.Sub task under: #16367