-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add quota to endpoint status response #17877
Conversation
This adds the configured backend quota bytes to the endpoint status response. related discussion in etcd-io#17821 Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
seems the robustness is failing on cert issues from alexellis/arkade#1056 |
If the test is failing, could it be due to trying to download vmmeter or something else via arkade? The |
Overall looks good to me. The change is clear and straightforward! Thanks @tjungblu |
Link to #17872 |
From (uses curl/sh and the utility domain)
=> To (Downloads directly from GitHub's releases page) - uses: alexellis/arkade-get@master
with:
vmmeter: latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We also need to change the client side, including |
I think Scott had this in #17871 Shall we also backport this? |
Usually we don't backport new feature, but I am not against it if other members/contributors agree to backport it. We need to ensure it doesn't break any existing client, for example an application which depends on the old etcd client SDK can still work with a new etcdserver. |
it is not critical for us to have in 3.5, but it's also not a big and invasive change.
Wouldn't protobuf just flag this as an unknown field? |
For this PR, it's safe. My point is that we don't have such mix-version test cases,
It can be discussed separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @tjungblu
@tjungblu Please update 3.6 changelog for now. thx. If we decide to backport the PR to 3.5 later, we can update the changelog for 3.5 (revert the changelog for 3.6) by then. |
change from etcd-io#17877 Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
This adds the configured backend quota bytes to the endpoint status response. related discussion in #17872