Skip to content

[HOTFIX] Fix WebSocket provider watching. #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2018
Merged

[HOTFIX] Fix WebSocket provider watching. #145

merged 1 commit into from
Jul 22, 2018

Conversation

e00dan
Copy link
Contributor

@e00dan e00dan commented Jul 22, 2018

  1. Dynamically generate id to avoid collision.
  2. Provide at least one mandatory argument to eth_getFilterLogs.

@coveralls
Copy link

coveralls commented Jul 22, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 869

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.08%) to 67.203%
Files with Coverage Reduction New Missed Lines %
src/Scanner/Scanner.ts 1 80.18%
Totals Coverage Status
Change from base Build 866: 0.08%
Covered Lines: 406
Relevant Lines: 576
💛 - Coveralls

@e00dan e00dan merged commit 1cdd8c9 into master Jul 22, 2018
@e00dan e00dan deleted the bugfix/fix-watching-ws branch July 22, 2018 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josipbagaric josipbagaric josipbagaric approved these changes

@lsaether lsaether lsaether approved these changes

@kosecki123 kosecki123 Awaiting requested review from kosecki123

@adibas03 adibas03 Awaiting requested review from adibas03

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@e00dan @coveralls @josipbagaric @lsaether