Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-geth: Update to latest op-geth with upstream 1.12.0 changes #6155

Merged
merged 8 commits into from
Jul 25, 2023

Conversation

ajsutton
Copy link
Contributor

Description

Update op-geth to latest version with upstream v1.12.0 changes.

@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2023

⚠️ No Changeset found

Latest commit: 554b0da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jun 26, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 554b0da
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64c019c57aa78c000824ab1b

@tynes
Copy link
Contributor

tynes commented Jun 26, 2023

Rebase will fix the failing contracts checks

@ajsutton ajsutton force-pushed the aj/op-geth-1.12.0 branch 2 times, most recently from 345600e to da2f452 Compare June 29, 2023 04:40
@mergify
Copy link
Contributor

mergify bot commented Jun 30, 2023

Hey @ajsutton! This PR has merge conflicts. Please fix them before continuing review.

@semgrep-app
Copy link
Contributor

semgrep-app bot commented Jul 9, 2023

Semgrep found 1 nondeterministic-select finding:

  • op-proposer/proposer/l2_output_submitter.go: L350-375

Logic executed as a result of ticker ticker may execute more times than desired.
When both ticker and l.done are written to at the same time, the scheduler randomly picks a
case to execute. As a result, the ticker.C may excute one more time than expected.

Ignore this finding from nondeterministic-select.

@ajsutton ajsutton force-pushed the aj/op-geth-1.12.0 branch 4 times, most recently from 612ffe5 to ea940d8 Compare July 9, 2023 23:32
@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Merging #6155 (554b0da) into develop (2eb8cee) will increase coverage by 0.12%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6155      +/-   ##
===========================================
+ Coverage    40.61%   40.74%   +0.12%     
===========================================
  Files          465      465              
  Lines        33422    33422              
  Branches      1949     1949              
===========================================
+ Hits         13576    13619      +43     
+ Misses       18366    18329      -37     
+ Partials      1480     1474       -6     
Flag Coverage Δ
bedrock-go-tests 43.94% <ø> (+0.01%) ⬆️
cannon-go-tests 62.40% <ø> (ø)
chain-mon-tests 26.95% <ø> (ø)
common-ts-tests 26.82% <ø> (ø)
contracts-bedrock-tests 44.62% <ø> (+3.01%) ⬆️
contracts-ts-tests 6.88% <ø> (ø)
core-utils-tests 44.24% <ø> (ø)
sdk-next-tests 42.60% <ø> (ø)
sdk-tests 42.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Jul 20, 2023

Hey @ajsutton! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added conflict and removed conflict labels Jul 20, 2023
@ajsutton ajsutton force-pushed the aj/op-geth-1.12.0 branch 2 times, most recently from e6b5fbc to e6d02a5 Compare July 24, 2023 22:14
@mergify mergify bot added the A-indexer Area: indexer label Jul 25, 2023
@mergify mergify bot requested a review from roninjin10 July 25, 2023 01:07
@ajsutton ajsutton marked this pull request as ready for review July 25, 2023 01:24
@ajsutton ajsutton requested review from a team as code owners July 25, 2023 01:24
@ajsutton ajsutton changed the title op-geth: Update to draft of op-geth with upstream 1.12.0 changes op-geth: Update to latest op-geth with upstream 1.12.0 changes Jul 25, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 25, 2023

Hey @ajsutton! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 25, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 25, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jul 25, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit d46deb8 into develop Jul 25, 2023
11 of 12 checks passed
@OptimismBot OptimismBot deleted the aj/op-geth-1.12.0 branch July 25, 2023 19:08
@mergify mergify bot removed the on-merge-train label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-indexer Area: indexer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants