feat(examples) interoperable tictactoe frontend #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying supersim with
|
| Latest commit: |
b21eea3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d8513b9e.supersim.pages.dev |
| Branch Preview URL: | https://example-tictactoe.supersim.pages.dev |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hamdiallam and the rest of your teammates on |
hamdiallam
force-pushed
the
interop.tictactoe
branch
from
d083ddf
to
ea8442d
Compare
hamdiallam
force-pushed
the
example.tictactoe
branch
2 times, most recently
from
0e74032
to
9058b4a
Compare
hamdiallam
force-pushed
the
interop.tictactoe
branch
from
9d2de09
to
66a6713
Compare
hamdiallam
force-pushed
the
example.tictactoe
branch
from
9058b4a
to
c344f95
Compare
hamdiallam
changed the title
nitaliano
reviewed
Oct 7, 2024
nitaliano
reviewed
Oct 7, 2024
hamdiallam
force-pushed
the
interop.tictactoe
branch
from
66a6713
to
4ddbcc1
Compare
hamdiallam
force-pushed
the
example.tictactoe
branch
from
7e25673
to
fffa1a9
Compare
hamdiallam
changed the title
hamdiallam
force-pushed
the
example.tictactoe
branch
from
fffa1a9
to
ca082e9
Compare
hamdiallam
force-pushed
the
example.tictactoe
branch
2 times, most recently
from
2fda160
to
44317a8
Compare
nitaliano
approved these changes
Oct 15, 2024
| @@ -0,0 +1 @@ | |||
| {"root":["./src/app.tsx","./src/main.tsx","./src/vite-env.d.ts","./src/components/board.tsx","./src/components/connectwallet.tsx","./src/components/gamelists.tsx","./src/components/newgame.tsx","./src/components/square.tsx","./src/constants/chains.ts","./src/constants/tictactoe.ts","./src/hooks/useacceptgame.ts","./src/hooks/usegames.ts","./src/hooks/usemakemove.ts","./src/hooks/usenewgame.ts","./src/hooks/useplayergames.ts","./src/types/game.ts"],"errors":true,"version":"5.6.2"} | |||
There was a problem hiding this comment.
you can gitignore this and the node tsbuildinfo files https://github.com/ethereum-optimism/ecosystem/blob/acfd4b41e800214c5e56b3a408970c14c32eb332/.gitignore#L13C1-L13C24
| games: Game[] | ||
| } | ||
|
|
||
| const AvailableGames: React.FC<AvailableGamesProps> = ({ games }) => { |
There was a problem hiding this comment.
you can also write the above like below to help with how verbose it can get and not have to deal with React changing it's types like it does sometimes. wouldn't actually change anything on this PR just adding a comment for learning
const AvailableGames = ({ games }: AvailableGamesProps)
There was a problem hiding this comment.
ahh nice didn't know that
Comment on lines
87
to
99
| const cellBackgroundColor = (row: number, col: number) => { | ||
| if (!gameEndingMoves) { return '#F2F3F8' } | ||
|
|
||
| const move = game.moves[row][col] | ||
|
|
||
| // winning cell | ||
| if (move == 1 && gameEndingMoves.some(move => move[0] === row && move[1] === col)) { return '#D6FFDA' } | ||
|
|
||
| // losing cell | ||
| if (move == 2 && gameEndingMoves.some(move => move[0] === row && move[1] === col)) { return '#FFD6D6' } | ||
|
|
||
| return '#F2F3F8' | ||
| } |
There was a problem hiding this comment.
it would be better to do this type of logic with classnames
There was a problem hiding this comment.
agreed, this will be apart of the cleanup
|
For the styles i think we can move this over to tailwind once it gets merged in will make the styling and logic around it much cleaner |
hamdiallam
force-pushed
the
interop.tictactoe
branch
from
4ddbcc1
to
418ca2e
Compare
hamdiallam
force-pushed
the
example.tictactoe
branch
from
44317a8
to
e08030f
Compare
hamdiallam
force-pushed
the
example.tictactoe
branch
from
e08030f
to
b21eea3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/contracts/scripts/tictactoe/Deployto each L2 chainTODO: