Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timestamp as ABI type #46

Closed
chriseth opened this issue Dec 11, 2015 · 8 comments
Closed

timestamp as ABI type #46

chriseth opened this issue Dec 11, 2015 · 8 comments
Labels

Comments

@chriseth
Copy link
Contributor

Timestamps are quite common in smart contracts, Solidity even has special keywords for handling time. It would improve user interfaces (especially the auto-generated like the "smart wallet") if web3.js would know that a specific variable is a timestamp, so values could be rendered differently and special inputs could be provided.

@alexvandesande
Copy link

I support this immensely. I just added this week a hack attempt of differentiation on the wallet. Now overtime it finds a uint that is between 1400000000 and 1800000000 and that doesn't end in 000 it will add the equivalent conversion to timestamp besides it.

(edit)

Also, I'd like to point out that the input type date is a supported html5 spec and that many browsers, specially mobile ones, already have a custom interface for picking date and time.

@wanderer wanderer added the ABI label Dec 23, 2015
@chriseth
Copy link
Contributor Author

chriseth commented Jan 8, 2016

Do we want to differentiate between timestamp (seconds since the unix epoch) and timespan (seconds)?

@frozeman
Copy link
Contributor

frozeman commented Jan 8, 2016

no, i would only add timestamp as its a "data type" for most interfaces, but for time span i don't see a reason, why we want to standardise that. Any comments?

@chriseth
Copy link
Contributor Author

chriseth commented Jan 8, 2016

For an automatic UI, it makes a tremendous difference whether you have a timestamp or a time span.

@alexvandesande
Copy link

I think timestamp is much more common. Whenever I use a time span variable
it's usually a uint for some sort of measure (number of minutes, amount of
days, etc) and don't really need seconds standardisation..

On Fri, Jan 8, 2016 at 8:09 AM, chriseth notifications@github.com wrote:

For an automatic UI, it makes a tremendous difference whether you have a
timestamp or a time span.


Reply to this email directly or view it on GitHub
#46 (comment).

Alex Van de Sande
UX Designer

@axic
Copy link
Member

axic commented Aug 7, 2016

Whenever I use a time span variable it's usually a uint for some sort of measure (number of minutes, amount of days, etc) and don't really need seconds standardisation..

One could say that timespan is standardised as seconds and that allows the UI to show it in units it likes, i.e. minutes, days, etc.

@github-actions
Copy link

There has been no activity on this issue for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the stale label Jan 18, 2022
@github-actions
Copy link

github-actions bot commented Feb 1, 2022

This issue was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this as completed Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants