Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add difficulty bomb delay to eip 858 #1346

Merged
merged 4 commits into from
Aug 28, 2018
Merged

Conversation

cslarson
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-X.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your Github username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eip-automerger
Copy link

eip-automerger commented Aug 22, 2018

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • File assets/eip-858/calculations.md is not an EIP
  • EIP 858 requires approval from one of (cslarson@gmail.com)

EIPS/eip-858.md Outdated

## Rationale
partly TBD
This will delay the difficulty bomb by 42 million seconds (approximately 1.4 years). The difficulty bomb remains a community supported mechanism to aid a future transition to POS.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are delaying it by 6 million blocks, so this is rather ~3 years.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. I've amended now to reflect a delay of 2m blocks, or roughly a year.

@ghost
Copy link

ghost commented Aug 23, 2018

Haha this is great 👍

@Arachnid Arachnid merged commit dcbe696 into ethereum:master Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants