Errata for EIP-1052 empty account #2144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepyakin
reviewed
Jun 24, 2019
| @@ -24,7 +24,7 @@ takes one argument from the stack, zeros the first 96 bits | |||
| and pushes to the stack the keccak256 hash of the code of the account | |||
| at the address being the remaining 160 bits. | |||
|
|
|||
| In case the account does not exist `0` is pushed to the stack. | |||
| In case the account does not exist or is empty `0` is pushed to the stack. | |||
There was a problem hiding this comment.
Did you mean it's bytecode empty or is there another notion of emptyness?
Suggested change
| In case the account does not exist or is empty `0` is pushed to the stack. | |
| In case the account does not exist or the bytecode is empty `0` is pushed to the stack. |
There was a problem hiding this comment.
We’re using EIP-161’s definition of “empty” here — having no nonce, balance or code.
There was a problem hiding this comment.
Shouldn't it note as a comment that EIP-161's definition is used?
There was a problem hiding this comment.
Yes, I'd like to have this comment as well. Something like
or is empty (as defined by EIP-161)
Arachnid
approved these changes
Aug 12, 2019
|
@chfast is it clear to merge? |
chfast
approved these changes
Nov 5, 2019
axic
reviewed
Nov 22, 2019
| @@ -24,7 +24,7 @@ takes one argument from the stack, zeros the first 96 bits | |||
| and pushes to the stack the keccak256 hash of the code of the account | |||
| at the address being the remaining 160 bits. | |||
|
|
|||
| In case the account does not exist `0` is pushed to the stack. | |||
| In case the account does not exist or is empty `0` is pushed to the stack. | |||
There was a problem hiding this comment.
Suggested change
| In case the account does not exist or is empty `0` is pushed to the stack. | |
| In case the account does not exist or is empty (as defined by [EIP-161](https://eips.ethereum.org/EIPS/eip-161)) `0` is pushed to the stack. |
There was a problem hiding this comment.
It seems @sorpaas has disabled maintainers' access to his fork. Will need to create a new PR.
chfast
approved these changes
Nov 22, 2019
| @@ -24,7 +24,7 @@ takes one argument from the stack, zeros the first 96 bits | |||
| and pushes to the stack the keccak256 hash of the code of the account | |||
| at the address being the remaining 160 bits. | |||
|
|
|||
| In case the account does not exist `0` is pushed to the stack. | |||
| In case the account does not exist or is empty `0` is pushed to the stack. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errata to clarify EIP-1052's behavior in case it meets with EIP-161's empty account. Geth/Aleth is having this behavior already. Parity previously will return
keccak([])for empty accounts, and now changed to return0x0as well in openethereum/parity-ethereum#10775Related to test
stExtCodeHash/codeCopyZero.