Update to canonical eip-X format #2734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @Souptacular @axic @nicksavers @Arachnid @gcolvin for review. |
|
Also see: #2737 |
|
I have added the style guide to EIP-1 itself. Please review the copy and let me know if it is acceptable. A potential next task is to comb through the repo and expunge all |
lightclient
force-pushed
the
update-eip-references
branch
from
face3e8
to
5e763be
Compare
|
I didn't read any dissent in the meeting, and some agreement, with the only real strongly held (from the wording) opinion being that we should pick a standard and go with it. We have used EIP-X historically, and that is what this PR proposes, so I'm going to merge it. We can always change it later if people disagree. |
2 tasks
tkstanczak
pushed a commit
to tkstanczak/EIPs
that referenced
this pull request
Nov 7, 2020
It appears that the format `EIP-X` is preferred to `EIPX`: ```console $ grep "EIP-[0-9]+" * | wc -l 373 $ grep "EIP[0-9]+" * | wc -l 118 ``` Also note that several of the `EIPX` references are coming from `index.html` and `EIPS/eip-1.md`. ```console $ grep "EIP[0-9]+" index.html | wc -l 4 $ grep "EIP[0-9]+" EIPS/eip-1.md | wc -l 13 ``` I have updated `index.html` and `eip-1` accordingly.
Arachnid
pushed a commit
to Arachnid/EIPs
that referenced
this pull request
Mar 6, 2021
It appears that the format `EIP-X` is preferred to `EIPX`: ```console $ grep "EIP-[0-9]+" * | wc -l 373 $ grep "EIP[0-9]+" * | wc -l 118 ``` Also note that several of the `EIPX` references are coming from `index.html` and `EIPS/eip-1.md`. ```console $ grep "EIP[0-9]+" index.html | wc -l 4 $ grep "EIP[0-9]+" EIPS/eip-1.md | wc -l 13 ``` I have updated `index.html` and `eip-1` accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the format
EIP-Xis preferred toEIPX:Also note that several of the
EIPXreferences are coming fromindex.htmlandEIPS/eip-1.md.I have updated
index.htmlandeip-1accordingly.