Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move EIP-712 to review #3497

Merged
merged 4 commits into from
Jun 2, 2021
Merged

Move EIP-712 to review #3497

merged 4 commits into from
Jun 2, 2021

Conversation

lightclient
Copy link
Member

Seems like we can start inching this to final? @recmo @LogvinovLeon @dekz

@alita-moore
Copy link
Contributor

alita-moore commented Apr 15, 2021

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

 - EIP 712 state was changed from draft to review

@recmo @LogvinovLeon @dekz

@alita-moore alita-moore reopened this Apr 16, 2021
@lightclient
Copy link
Member Author

bump @recmo @LogvinovLeon @dekz

@lightclient
Copy link
Member Author

Thanks @LogvinovLeon :)

@lightclient
Copy link
Member Author

@alita-moore seems like the bot is blocking this merge too?

@MicahZoltu MicahZoltu closed this Jun 2, 2021
@MicahZoltu MicahZoltu reopened this Jun 2, 2021
@MicahZoltu
Copy link
Contributor

The bot block is scheduled to be fixed soon™ I believe. The solution will be to make it so an editor can approve the PR when it is changing status and the bot will unblock at that point.

@MicahZoltu MicahZoltu merged commit 876f4b5 into master Jun 2, 2021
@MicahZoltu MicahZoltu deleted the lightclient-patch-2 branch June 2, 2021 13:34
PhABC pushed a commit to PhABC/EIPs that referenced this pull request Jan 25, 2022
* Update eip-712.md

* just adding space to make sure bot works properly

* reverting afforementioned space

Co-authored-by: Alita Moore <alita.moore805@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants