Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-5313 Light Contract Ownership #5313

Merged
merged 14 commits into from
Jul 22, 2022
Merged

EIP-5313 Light Contract Ownership #5313

merged 14 commits into from
Jul 22, 2022

Conversation

fulldecent
Copy link
Contributor

New EIP

@eth-bot
Copy link
Collaborator

eth-bot commented Jul 22, 2022 •
edited
Loading

All tests passed; auto-merging...

(pass) eip-5313.md

classification
updateEIP
  • passed!

@github-actions
Copy link

The commit b2f9c03 (as a parent of 5874a3c) contains errors. Please inspect the Run Summary for details.

@github-actions
Copy link

The commit 1fad592 (as a parent of 96527db) contains errors. Please inspect the Run Summary for details.

@github-actions
Copy link

The commit 3b1f7cf (as a parent of b60bb60) contains errors. Please inspect the Run Summary for details.

Pandapip1
Pandapip1 suggested changes Jul 22, 2022
View reviewed changes
EIPS/eip-5313.md Outdated Show resolved Hide resolved
@github-actions
Copy link

The commit 5b38b29 (as a parent of 7371015) contains errors. Please inspect the Run Summary for details.

@github-actions
Copy link

The commit 7845367 (as a parent of 3831677) contains errors. Please inspect the Run Summary for details.

@fulldecent fulldecent changed the title Create eip-xxx.md EIP-5313 Light Contract Ownership Jul 22, 2022
@Pandapip1
Copy link
Member

Pandapip1 commented Jul 22, 2022 •
edited
Loading

Deleted outdated comments. Please fix the last two and it should be good to go!

Pandapip1
Pandapip1 suggested changes Jul 22, 2022
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, there are a few more things that need fixing

EIPS/eip-5313.md Outdated Show resolved Hide resolved
EIPS/eip-5313.md Outdated Show resolved Hide resolved
EIPS/eip-5313.md Outdated Show resolved Hide resolved
@github-actions
Copy link

The commit 6243cf2 (as a parent of 627eb6e) contains errors. Please inspect the Run Summary for details.

Pandapip1
Pandapip1 reviewed Jul 22, 2022
View reviewed changes
EIPS/eip-5313.md Outdated Show resolved Hide resolved
Pandapip1
Pandapip1 reviewed Jul 22, 2022
View reviewed changes
EIPS/eip-5313.md Outdated Show resolved Hide resolved
@fulldecent @Pandapip1
Update EIPS/eip-5313.md
8734880 
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
fulldecent and others added 4 commits July 22, 2022 15:52
@fulldecent @Pandapip1
Update EIPS/eip-5313.md
5d671b3 
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
@fulldecent @Pandapip1
Update EIPS/eip-5313.md
7a270e7 
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
@fulldecent @Pandapip1
Update EIPS/eip-5313.md
0e87441 
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
@fulldecent @Pandapip1
Update EIPS/eip-5313.md
1a3c189 
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
@fulldecent @Pandapip1
Update EIPS/eip-5313.md
659a15b 
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
@fulldecent
Copy link
Contributor Author

@Pandapip1 All caught up, thank you

@github-actions
Copy link

The commit cd7a635 (as a parent of 4c3b10b) contains errors. Please inspect the Run Summary for details.

@github-actions
Copy link

The commit 5d671b3 (as a parent of 62bb93f) contains errors. Please inspect the Run Summary for details.

@github-actions
Copy link

The commit 7a270e7 (as a parent of 9435187) contains errors. Please inspect the Run Summary for details.

Pandapip1
Pandapip1 approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Congrats on probably being the first person to get a draft of an EIP merged within 1 hour of submission.

@github-actions
Copy link

The commit 8734880 (as a parent of cc6c128) contains errors. Please inspect the Run Summary for details.

@github-actions
Copy link

The commit 1a3c189 (as a parent of 11dd312) contains errors. Please inspect the Run Summary for details.

@github-actions
Copy link

The commit 0e87441 (as a parent of e582064) contains errors. Please inspect the Run Summary for details.

Pandapip1
Pandapip1 approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kodiakhq please merge

@kodiakhq kodiakhq bot merged commit 4ae69c5 into ethereum:master Jul 22, 2022
@SamWilsn SamWilsn mentioned this pull request Jul 22, 2022
Open
@MicahZoltu
Copy link
Contributor

This EIP is a breath of fresh air @fulldecent, so thanks! Short, concise, doesn't delve deeply into a history lesson, doesn't include references to external things, doesn't include anything more than absolutely necessary to standardize a useful feature, and has a meaningful Rationale and Security Considerations section.

I do think leaving out 165 is the right choice, even if this wasn't already a defacto standard as contracts can choose to implement 165 and thus can compose this and 165 freely on their own without need for a constraint here.

@Pandapip1
Copy link
Member

Totally agreed - this is definitely going to be the EIP I will use as "this is what EIPs should look like."

nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
@fulldecent @Pandapip1 @nachomazzara
EIP-5313 Light Contract Ownership (ethereum#5313)
40fb5b4 
* Create eip-xxx.md

* Update and rename eip-xxx.md to eip-5313.md

* Update eip-5313.md

* Update eip-5313.md

* Update eip-5313.md

* Relative link

* Add security talk

* Add rationale

* Update EIPS/eip-5313.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5313.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5313.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5313.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5313.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5313.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pandapip1 Pandapip1 Pandapip1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fulldecent @eth-bot @Pandapip1 @MicahZoltu