Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds @xinbenlv as an EIP Editor (#5502) #5703

Merged
merged 4 commits into from
Feb 8, 2023

Conversation

SamWilsn
Copy link
Contributor

Reopening discussion on #5502

@SamWilsn SamWilsn added the e-consensus Waiting on editor consensus label Sep 21, 2022
@eth-bot
Copy link
Collaborator

eth-bot commented Sep 21, 2022

All reviewers have approved. Auto merging...

Pandapip1
Pandapip1 previously approved these changes Dec 2, 2022
@Pandapip1
Copy link
Member

I think @xinbenlv's recent contributions are more than enough to demonstrate that he both knows the EIP process and has good proposals with which to improve it.

Pandapip1
Pandapip1 previously approved these changes Dec 2, 2022
@eth-bot eth-bot enabled auto-merge (squash) December 2, 2022 21:33
eth-bot
eth-bot previously approved these changes Dec 2, 2022
@Pandapip1
Copy link
Member

Not sure why that was enough to get @eth-bot to merge. I'm manually disabling auto-merge until at least one more editor is in agreement.

@xinbenlv
Copy link
Contributor

xinbenlv commented Dec 2, 2022

@Pandapip1 thank you for your support, but I think per Wednesday this has not gain consensus yet.

Copy link
Contributor

@xinbenlv xinbenlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs consensus, blocking merge

@xinbenlv
Copy link
Contributor

xinbenlv commented Dec 2, 2022

Just some thoughts about this nomination from my side:

On the meeting of Wednesday, I heard very warm encouragement and good words from you endorsing my editorial contributions and also some frank concern / uncertainty about whether my values "align with Ethereum".

I appreciate both the endorsement and the frank feedback.

It is true that I don't necessarily always hold identical procedural views with some editors, such as about whether to link to free source, external source or other procedures.

I never shy away from expressing what I think is the best for our EIP effort. But I also always do my best to debate, collaborate, solicit feedback and facilitate a consensus decision. In a lot of times this means withdrawing my own ideas, retrait from my preferences. When it comes to execution, I always follow the procedure/policy of group decision because I feel strongly about respecting consensus.

Some also voiced their concern because I drafted ERC-1202, ERC-5485 indicating the valuing of some societal or philosophical ideas of leveraging / bringing voting, sovereignty or governance onto chain, and they are not a fan of these ideas and question if these ideas align with / shall be allowed to exist in the movement of Ethereum. I see the technical ability to conduct voting or representing governance on-chain could help bring more efficiency and a stronger trust enforced by math. My ideas might be wrong, but I have always been happy to chat, debate, hear alternatives and open to be convinced. But I see such ideas less relevant to evaluate an EIP editor nomination.

I feel the most relevant values about editing are openness, agree to disagree, respect consensus, debate the ideas not the person. These are my core values that I will never consider compromising. If someone did think any of these core values misalign with Ethereum or EIP efforts, I think I might not be a good fit in this community. But I don't think this is what my respected editors mean.

In general, I see brining diverse ideas and views as healthy and helpful for all society so long as everyone also actively listen to others', be able to reach consensus and respect group decision when made.

That's why I was deeply moved to hear @Pandapip1 nominated me for editorship, despite we debate link policy so hard on opposite side of this procedural decision.

Within many things in Ethereum, I particularly value the "EIP effort", or the ability that anyone could propose ideas and welcome to provide feedback. Because I value openness to contribution.

Personally I contributed to several contributor communities, including Wikipedia. And I also have cofounded several and get to setup governance structures multiple times. Every time, I work hard to bring open-contributor spirit to the community I contribute. In some communities I even started its own ["X"IP](github.com/zgzgorg/ZGIP) because I think XIP is having a place to propose and share ideas is a great way to harness wisdoms and help contributors have more sense of ownership by allowing them to shape the direction. And this is also why I value so much for this nomination.

Now, if "being editors" is about "to have power to approve merge or make governing decisions" and thus they prefer such power shall not be shared with someone who they don't agree with, I totally understand and am totally fine not to to have such power at all.

If being editor is about recognition of contributions and invitation to take more responsibility and deeper involvement, this is the reason I accept the nomination. because I feel editorship is more about the later.

I am grateful that some of you enjoy my contributions and look forward to continue to contribute in any capacity this EIP effort wants me to.

@Pandapip1
Copy link
Member

Pandapip1 commented Dec 3, 2022

I feel the most relevant values about editing are openness, agree to disagree, respect consensus, debate the ideas not the person. These are my core values that I will never consider compromising.

FWIW I strongly agree with this.

@SamWilsn
Copy link
Contributor Author

SamWilsn commented Jan 25, 2023

@gcolvin is in favour of adding @xinbenlv. In light of the lack of ERC editors, I am also in favour.

I believe @lightclient is still opposed, and blocking this change.

@gcolvin enumerated our options if this is the case:

  1. We don't have complete consensus, so we do not add @xinbenlv as an editor.
  2. We don't have complete consensus, but the rest of the editors feel strongly enough to go ahead without @lightclient. We do add @xinbenlv as an editor.

I don't know which of (1) and (2) we're at right now, and I don't think we can move forward without more editors on a call.

@xinbenlv
Copy link
Contributor

Thanks @SamWilsn for documenting.

I also realize, both (1) and (2) are on the assumption that @lightclient is still strongly favor of blocking this PR.

There is also an (3) possibility that with more time co-working with me, @lightclient now feels open to unblock this PR.

@xinbenlv
Copy link
Contributor

xinbenlv commented Feb 6, 2023

Hi @lightclient, we discussed #5703 last EIPIP documented the result. We are hoping to get this discussed and hopefully come up with a decision in this EIPIP meeting. Your input is greatly appreciated. Would you mind share your views on this thread? 🙏

@gcolvin
Copy link
Contributor

gcolvin commented Feb 7, 2023

I hardly understand what it means for a person's values to "align with Ethereum". It's a large, diverse, diffuse community with lots of controversy, disagreements, and politics. As Editors, we long ago decided that our role was not to judge the content of a proposal, only its form.

We made this decision when Yoichi resigned as an Editor rather than be involved with the EIP for recovering provably lost funds. Among the Editors, Nick Johnson argued that if Ether was provably lost then, Why wouldn't you return it to its owner? Yoichi believed that we should never violate immutability, and that he would be in danger of violating Japanese anti-hacking law if he was to merge the PR. I felt obliged, on 1st Amendment grounds, to merge it regardless of my beliefs. I don't recall Hudson's opinion. In the end we merged it without Yoichi, Nick started into automating the process, and we vowed to not make value judgements.

Compared to all that our disagreements about things like external links are as nothing. I think our policy is way too restrictive, but am not blocking consensus. I don't see that it matters that I'm not "value-aligned". We can see how our current policy works out, and change it if we need to. And opinions about on-chain governance are irrelevant to being an Editor. I generally oppose it, but it so what? I also opposed risking ASICs taking over the PoW chain, locking funds on the beacon chain, requiring 32 ETH to run a validator, and lots more. So be it.

@gcolvin
Copy link
Contributor

gcolvin commented Feb 7, 2023

So @xinbenlv has worked hard and contributed a lot already. I can see many reasons to bring him aboard, and no reasons not to.

gcolvin
gcolvin previously approved these changes Feb 7, 2023
@Pandapip1 Pandapip1 dismissed stale reviews from gcolvin, eth-bot, and themself via a3a366b February 8, 2023 21:12
@eth-bot eth-bot enabled auto-merge (squash) February 8, 2023 21:13
eth-bot
eth-bot previously approved these changes Feb 8, 2023
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding @xinbenlv as a non-governance ERC/Meta/Informational editor, as per the consensus reached on the most recent EIPIP meeting.

@Pandapip1 Pandapip1 removed this from the Manual Merge Queue milestone Feb 8, 2023
@eth-bot eth-bot merged commit 8a66f1f into ethereum:master Feb 8, 2023
@poojaranjan poojaranjan mentioned this pull request Feb 9, 2023
15 tasks
iseriohn pushed a commit to iseriohn/EIP-NFT-Rights-Management that referenced this pull request Feb 16, 2023
* Adds @xinbenlv as an EIP Editor (ethereum#5502)

* Add xinbenlv to new config file

---------

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e-consensus Waiting on editor consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants