Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-lockable-tokens #6299

Closed
wants to merge 1 commit into from
Closed

Conversation

Zionodes
Copy link

@Zionodes Zionodes commented Jan 8, 2023

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@Zionodes Zionodes requested a review from eth-bot as a code owner January 8, 2023 17:53
@github-actions github-actions bot added c-new Creates a brand new proposal e-number Waiting on EIP Number assignment s-draft This EIP is a Draft labels Jan 8, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Jan 8, 2023

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(fail) EIPS/eip-lockable-tokens.md

classification
ambiguous
  • 'EIPS/eip-lockable-tokens.md' must be in eip-###.md format; this error will be overwritten upon relevant editor approval

@github-actions
Copy link

github-actions bot commented Jan 8, 2023

The commit 2741ad1 (as a parent of 2ccb7ed) contains errors.
Please inspect the Run Summary for details.

@@ -0,0 +1,134 @@
---
eip: <to be assigned>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
eip: <to be assigned>
eip: 6299

Don't forget to rename the file too :3

---
eip: <to be assigned>
title: Lockable tokens
description: The extension for the ERC-20 and ERC-777 tokens to be locked for the lending purposes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: The extension for the ERC-20 and ERC-777 tokens to be locked for the lending purposes
description: Extension for ERC-20 and ERC-777 tokens to be locked for lending purposes

discussions-to: https://ethereum-magicians.org/t/eip-draft-lockable-tokens/12488
status: Draft
type: Standards Track
category (*only required for Standards Track): ERC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
category (*only required for Standards Track): ERC
category: ERC


## Abstract

This is standard to gave to the fungible tokens ability to be locked from the other users. It is needed in some cases, for example in a lending purposes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This is standard to gave to the fungible tokens ability to be locked from the other users. It is needed in some cases, for example in a lending purposes.
This standard gives fungible tokens the ability to be locked from the other users. It is needed in some cases, for example when lending tokens.

Comment on lines +114 to +120
This EIP's goal, as mentioned in the abstract, is to have a simple interface for serving token lock. Here are a few design decisions and why they were made:

- Simple lock/unlock mechanism
- Unlike standard `transfer` / `transferTo` it allow to leave pledged tokens on the owner's account.
- Possibility to change the locked amount in selected limit.
- Forced collateral
- Possibility to collect the pledged tokens and to clear the loan.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Rationale section should explain individual technical choices made within this proposal itself. This content reads more like it belongs in the Motivation section.


## Backwards Compatibility

This standard is an a extension for the any fungible token standards.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This standard is an a extension for the any fungible token standards.
This standard is an a extension for any of the fungible token standards.

@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label May 16, 2023
@github-actions
Copy link

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-number Waiting on EIP Number assignment s-draft This EIP is a Draft w-ci Waiting on CI to pass w-stale Waiting on activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants