Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Math checking in EVM #6888

Merged
merged 18 commits into from
May 16, 2023
Merged

Conversation

RenanSouza2
Copy link
Contributor

This EIP adds many math checking to EVM arithmetic. The list includes underflows, overflows, division by zero. A new opcode is added to get the flags and clean them.

@eth-bot
Copy link
Collaborator

eth-bot commented Apr 17, 2023

✅ All reviewers have approved.

@eth-bot eth-bot changed the title EIP: math checking Add EIP: Math checking in EVM Apr 17, 2023
@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Apr 17, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Apr 17, 2023
@SamWilsn SamWilsn closed this Apr 17, 2023
@SamWilsn SamWilsn reopened this Apr 17, 2023
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

EIPS/eip-math-check.md Outdated Show resolved Hide resolved
EIPS/eip-math-check.md Outdated Show resolved Hide resolved
@eth-bot eth-bot enabled auto-merge (squash) April 17, 2023 16:09
eth-bot
eth-bot previously approved these changes Apr 17, 2023
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Apr 17, 2023
auto-merge was automatically disabled April 17, 2023 16:24

Head branch was pushed to by a user without write access

@eth-bot eth-bot enabled auto-merge (squash) April 17, 2023 16:25
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

eth-bot
eth-bot previously approved these changes Apr 17, 2023
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

auto-merge was automatically disabled April 17, 2023 22:56

Head branch was pushed to by a user without write access

@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core labels Apr 17, 2023
@eth-bot eth-bot enabled auto-merge (squash) April 17, 2023 22:57
@eth-bot eth-bot enabled auto-merge (squash) April 26, 2023 12:40
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

eth-bot
eth-bot previously approved these changes Apr 26, 2023
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

auto-merge was automatically disabled April 27, 2023 14:22

Head branch was pushed to by a user without write access

@eth-bot eth-bot enabled auto-merge (squash) April 27, 2023 14:23
eth-bot
eth-bot previously approved these changes Apr 27, 2023
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Apr 27, 2023
auto-merge was automatically disabled April 27, 2023 19:24

Head branch was pushed to by a user without write access

@eth-bot eth-bot enabled auto-merge (squash) April 27, 2023 19:25
eth-bot
eth-bot previously approved these changes Apr 27, 2023
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@github-actions
Copy link

The commit eca141c (as a parent of 0e8ddbe) contains errors.
Please inspect the Run Summary for details.

auto-merge was automatically disabled April 28, 2023 16:53

Head branch was pushed to by a user without write access

@eth-bot eth-bot enabled auto-merge (squash) April 28, 2023 16:54
eth-bot
eth-bot previously approved these changes Apr 28, 2023
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Apr 28, 2023
auto-merge was automatically disabled May 2, 2023 00:29

Head branch was pushed to by a user without write access

@eth-bot eth-bot enabled auto-merge (squash) May 2, 2023 00:29
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@SamWilsn SamWilsn dismissed lightclient’s stale review May 16, 2023 15:22

Looks like the changes were made

@eth-bot eth-bot merged commit fd6eb62 into ethereum:master May 16, 2023
@RenanSouza2 RenanSouza2 deleted the EIP-math-checking branch May 16, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants