Update EIP-6059: Clarify the backwards compatibility section #7261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The backwards compatibility section was updated to further clarify the proposal's relationship to EIP-721.
github-actions
bot
added
c-update
File
|
5 tasks
SamWilsn
reviewed
Jul 12, 2023
| @@ -450,6 +450,8 @@ This state change places the token in the pending array of the new parent token. | |||
|
|
|||
| The Nestable token standard has been made compatible with [ERC-721](./eip-721.md) in order to take advantage of the robust tooling available for implementations of ERC-721 and to ensure compatibility with existing ERC-721 infrastructure. | |||
|
|
|||
| The only incompatible part of the specification is the restriction to not use the token ID of 0. | |||
There was a problem hiding this comment.
I'm fine with this change, but would probably recommend something more specific, like:
Suggested change
| The only incompatible part of the specification is the restriction to not use the token ID of 0. | |
| The only incompatibility with ERC-721 is that Nestable tokens cannot use a token ID of 0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backwards compatibility section was updated to further clarify the proposal's relationship to EIP-721.