-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-5069: Replace handbook with charter #7468
Conversation
🛑 Auto merge failed. Please see logs for more details, and report this issue at the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Two comments from @gcolvin:
|
Thanks for the effort! I am very encouraged that this could reduce a lot of friction and boost productivity of editing! A few feedback:
This means the editors need to be able to properly track responses from others. What's our way to ensure such response.
For example, Apache requires all important conversation occurs in Emails so there is a integrated way to notify everyone. What's our preferred practice? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like there are some roles missing. Here is what I think needs specifying:
- Janitor/Moderator/<namehere>: Determining when consensus has been reached
- Governing Editor: Participates in governance, voting, and elections
- EIP Repo admin: Greater moderation powers; ability to make major configuration changes
- EIP Repo write: Lesser moderation powers; ability to make minor configuration changes
- EIP Editor: Reviews proposals. Is not necessarily a governing editor
There are a few editor-adjacent roles that have powers that also need specifying:
- eipw/eipw-action maintainers (that's currently @SamWilsn)
- eip-review-bot (and any other bots that interact using @eth-bot) maintainers (that's currently me, @Pandapip1)
- Website maintainers (me & @SamWilsn)
- Other CI maintainers (me & @SamWilsn)
Co-authored-by: Gavin John <gavinnjohn@gmail.com>
That's a great question @xinbenlv. I've tried to avoid implementation details as much as possible within this document, because I think they'll end up changing quite frequently. This particular issue falls directly under the Janitor's duty to "determine when rough consensus has been reached", so wherever the Janitor says opinions/votes have to be registered is where they have to be registered. If the Janitor is unreasonable, vote 'em out. |
I'd rather make an error by under-specifying than by over-specifying.
We've got this one ;)
So this would be "EIP Editor" as written today?
Hm... These feel too specific to GitHub and are maybe an implementation detail? If the Editors with admin rights misbehave, they can be removed as Editors. I'd love to grant "delete an issue" rights but there's something funky about our GitHub organization that prevents it (or so I've heard.)
So this would be someone who counts for approving PRs, but doesn't get to express opinions/votes for governance purposes? Does the idea of Topic Groups (see fb4a1a0) work for this? Or are you talking specifically approve PRs that only EIP Editors can approve? Does the delegation of powers paragraph cover this? An Editor could delegate their PR approving powers to anyone they choose.
Do these need to be called out in our organizational charter, or is this more like "If you have questions about this bot, talk to @Pandapip1"? |
I guess a lot of this can be covered by delegation. While that's not ideal, I won't block for it. Maybe a seperate document (or documents) detailing implementation-specific powers could be useful? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* Replace handbook with charter * Remove topic groups * Small grammar fix * Apply @Pandapip1's suggestions * Remove extra space * Update EIPS/eip-5069.md Co-authored-by: Gavin John <gavinnjohn@gmail.com> * s/Janitor/Keeper * Update eip-5069.md --------- Co-authored-by: Gavin John <gavinnjohn@gmail.com>
* Replace handbook with charter * Remove topic groups * Small grammar fix * Apply @Pandapip1's suggestions * Remove extra space * Update EIPS/eip-5069.md Co-authored-by: Gavin John <gavinnjohn@gmail.com> * s/Janitor/Keeper * Update eip-5069.md --------- Co-authored-by: Gavin John <gavinnjohn@gmail.com>
* Replace handbook with charter * Remove topic groups * Small grammar fix * Apply @Pandapip1's suggestions * Remove extra space * Update EIPS/eip-5069.md Co-authored-by: Gavin John <gavinnjohn@gmail.com> * s/Janitor/Keeper * Update eip-5069.md --------- Co-authored-by: Gavin John <gavinnjohn@gmail.com>
* Replace handbook with charter * Remove topic groups * Small grammar fix * Apply @Pandapip1's suggestions * Remove extra space * Update EIPS/eip-5069.md Co-authored-by: Gavin John <gavinnjohn@gmail.com> * s/Janitor/Keeper * Update eip-5069.md --------- Co-authored-by: Gavin John <gavinnjohn@gmail.com>
* Replace handbook with charter * Remove topic groups * Small grammar fix * Apply @Pandapip1's suggestions * Remove extra space * Update EIPS/eip-5069.md Co-authored-by: Gavin John <gavinnjohn@gmail.com> * s/Janitor/Keeper * Update eip-5069.md --------- Co-authored-by: Gavin John <gavinnjohn@gmail.com>
No description provided.