Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-5521: Move to Review #7632

Closed
wants to merge 55 commits into from
Closed

Conversation

OniReimu
Copy link
Contributor

@OniReimu OniReimu commented Sep 4, 2023

Move to Review

OniReimu and others added 30 commits August 22, 2022 13:48
This standard proposes an extension to ERC-721 Non-Fungible Tokens (NFTs) to construct reference relationships among NFTs.
Update eip number
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
@github-actions github-actions bot added c-status Changes a proposal's status s-review This EIP is in Review t-erc labels Sep 4, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Sep 4, 2023

File EIPS/eip-5521.md

Requires 1 more reviewers from @axic, @Pandapip1, @SamWilsn, @xinbenlv

@eth-bot eth-bot changed the title Propose moving to Review Update EIP-5521: Move to Review Sep 4, 2023
@eth-bot eth-bot added the e-review Waiting on editor to review label Sep 4, 2023
Add fig
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

The commit 1b681a5 (as a parent of 56ca37b) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Sep 4, 2023
Bugs fixed
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Sep 4, 2023
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You just need to flesh out your specification section a bit more, then you should be good to go.

EIPS/eip-5521.md Outdated Show resolved Hide resolved
EIPS/eip-5521.md Show resolved Hide resolved
EIPS/eip-5521.md Outdated Show resolved Hide resolved
@OniReimu
Copy link
Contributor Author

Hi @SamWilsn , in case you are not seeing the review re-request, would you like to have a look at the changes please and approve it if no further changes needed? Thank you.

@SamWilsn
Copy link
Contributor

I am closing this pull request because we are in the process of separating EIPs and ERCs into distinct repositories. Unfortunately, as far as we are aware, GitHub does not provide any tools to ease this migration, so every pull request will need to be re-opened manually.

As this is a PR to create / modify an ERC, I will kindly ask you to redirect this to the new repository at ethereum/ERCs. We have prepared a guide to help with the process.

If there is relevant history here, please link to this PR from the new pull request.

On behalf of the EIP Editors, I apologize for this inconvenience.

@SamWilsn SamWilsn closed this Oct 26, 2023
@SamWilsn
Copy link
Contributor

@OniReimu Hey! Sorry it's taken so long to get a review on this. I was caught up to somewhere in June before we split the repositories... I'll take a look once this pull request is reopened in the new repository!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-status Changes a proposal's status e-review Waiting on editor to review s-review This EIP is in Review t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants