Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-7495: Allow setting properties in StableContainer impl #7936

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Update EIP-7495: Allow setting properties in StableContainer impl #7936

merged 2 commits into from
Nov 29, 2023

Conversation

etan-status
Copy link
Contributor

No description provided.

@eth-bot
Copy link
Collaborator

eth-bot commented Oct 29, 2023 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Oct 29, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Oct 29, 2023
@etan-status
Copy link
Contributor Author

Errors don't have anything to do with this PR. Maybe the eth-bot stuff is broken when only assets but no .md files are modified :-)

@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels Oct 29, 2023
@etan-status
Copy link
Contributor Author

Ah, seems to just be the e-consensus tag that's a bit weird when not touching .md. The HTMLProofer issue seems to stem from the split into ERC.

@github-actions github-actions bot removed c-update Modifies an existing proposal t-core s-review This EIP is in Review labels Oct 29, 2023
@etan-status
Copy link
Contributor Author

@eth-bot rerun

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Oct 30, 2023
g11tech
g11tech previously approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@g11tech g11tech force-pushed the sz-setattr branch 2 times, most recently from b50d804 to 8ce7cad Compare November 14, 2023 11:06
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Nov 14, 2023
@g11tech
Copy link
Contributor

g11tech commented Nov 14, 2023

i think someone needs to rectify eip-6358 for the htmlproofer to pass

@etan-status
Copy link
Contributor Author

i think someone needs to rectify eip-6358 for the htmlproofer to pass

Seems to be related to ethereum/ERCs#40

The ERCs repo is a bit weird, it has assets/erc-XYZ folders, but most references seem to be for ../assets/eip-XYZ (eip instead of erc). The 6358 ref seems to have been changed to point to erc and now it breaks here.

@Pandapip1 maybe some insight?

@eth-bot eth-bot enabled auto-merge (squash) November 21, 2023 07:04
eth-bot
eth-bot approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@etan-status etan-status mentioned this pull request Nov 21, 2023
Closed
eth-bot
eth-bot approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@etan-status etan-status mentioned this pull request Nov 23, 2023
Merged
eth-bot
eth-bot previously approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@github-actions GitHub Actions
Copy link

The commit ee4098a (as a parent of bb2b7e69e81f267690d3859ed808003474ed78d7) contains errors.
Please inspect the Run Summary for details.

@etan-status
Copy link
Contributor Author

auto-merge was automatically disabled November 28, 2023 23:04

Head branch was pushed to by a user without write access

@etan-status etan-status dismissed stale reviews from eth-bot and g11tech via e7e871f November 28, 2023 23:04
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Nov 28, 2023
@eth-bot eth-bot enabled auto-merge (squash) November 29, 2023 08:30
eth-bot
eth-bot approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 9f20f20 into ethereum:master Nov 29, 2023
11 checks passed
@etan-status etan-status deleted the sz-setattr branch November 29, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g11tech g11tech g11tech approved these changes

@eth-bot eth-bot eth-bot approved these changes

Assignees
No one assigned
Labels
e-consensus Waiting on editor consensus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etan-status @eth-bot @g11tech