Update EIP-7069: Extend rationale about gas costs #8506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-update
|
✅ All reviewers have approved. |
pdobacz
reviewed
Apr 29, 2024
EIPS/eip-7069.md
Outdated
| @@ -121,6 +121,25 @@ The 63/64th rule is still applied, but | |||
| - At least `MIN_RETAINED_GAS` gas is retained prior to executing the callee, | |||
| - At least `MIN_CALLEE_GAS` gas is available to the callee. | |||
|
|
|||
| The `MIN_CALLEE_GAS` rule is a replacement for stipend: it simplifies the reasoning about the gas costs and is applied uniformly for all introduced `*CALL` instructions. | |||
There was a problem hiding this comment.
Suggested change
| The `MIN_CALLEE_GAS` rule is a replacement for stipend: it simplifies the reasoning about the gas costs and is applied uniformly for all introduced `*CALL` instructions. | |
| The `MIN_CALLEE_GAS` rule is a replacement for stipend: it simplifies the reasoning about the gas costs and is applied uniformly for all introduced `EXT*CALL` instructions. |
EIPS/eip-7069.md
Outdated
|
|
||
| - **Caller required gas**: the minimum amount of gas a caller is required to have to execute a call instruction, lower value causes caller's OOG, | ||
| - **Caller cost (burned gas)**: the amount of gas deducted from the caller to execute the instruction, this amount is not available to the callee, | ||
| - **Caller min retained gas**: the minimum amount of gas the caller is guaranteed to have after the call, if this cannot be guaranteed the call fails with 0 without even reaching the callee, |
There was a problem hiding this comment.
"fails with 0" would apply to old CALL instructions. EXT*CALL return 1 on the stack (EXTCALL_REVERT in evmone)
chfast
force-pushed
the
eip7069_rationale_gas_costs
branch
from
cd913b5
to
2f2c894
Compare
gumb0
approved these changes
May 8, 2024
eth-bot
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.