Update EIP-7702: updates for devnet4 #8929

lightclient · 2024-10-03T14:39:39Z

placeholder for further devnet changes.

outstanding clarifications to make (from my notes):

authorization should be invalid is nonce == 2^64 - 1
This case (add tx-level delegated account to warm)
Precompiles will not be run once delegated to (treated as empty accounts)
EXTCODEHASH puts 0 on stack if the 7702-delegated account it is delegates to does not exist in trie (as opposed to empty hash keccak256("") of accounts which exists in trie, but have no code, i.e. EOAs (non-delegated to))
delegations are not reverted in case transaction fails
if delegation target account does not exist, nonce is checked to be 0
is the price correct at 2500? is there incentive to use as alternative contract deployment?
limit chain id to uint64 and y_parity to uint8

eth-bot · 2024-10-03T14:40:07Z

✅ All reviewers have approved.

jochem-brouwer · 2024-10-03T20:54:48Z

Did you see #8905 and #8906? These address part of your notes :)

EDIT: sorry, just saw you already replied to those PRs :)

EIPS/eip-7702.md

eth-bot

All Reviewers Have Approved; Performing Automatic Merge...

eth-bot

All Reviewers Have Approved; Performing Automatic Merge...

jochem-brouwer · 2024-10-09T14:50:55Z

EIPS/eip-7702.md

@@ -73,7 +73,8 @@ At the start of executing the transaction, after incrementing the sender's nonce
 5. Verify the code of `authority` is either empty or already delegated.
 6. Verify the nonce of `authority` is equal to `nonce`. In case `authority` does not exist in the trie, verify that `nonce` is equal to `0`.
 7. Add `PER_EMPTY_ACCOUNT_COST - PER_AUTH_BASE_COST` gas to the global refund counter if `authority` exists in the trie.
-8. Set the code of `authority` to be `0xef0100 || address`. This is a delegation designation.
+8. Set the code of `authority` to be `0xef0100 || address`. This is a delegation designation. 
+    * As a special case, if `address` is `0x0000000000000000000000000000000000000000` do not write the designation. Clear the accounts code and reset the account's code hash to `0x0000000000000000000000000000000000000000000000000000000000000000`.


Why is the account code hash set to these zeros? It should be set to keccak256("")?

Ah you're right. Let me update it.

jochem-brouwer

I got some minor further questions / clarification comments :)

jochem-brouwer · 2024-10-09T16:15:43Z

EIPS/eip-7702.md

+
+The `PER_AUTH_BASE_COST` is the cost to process the authorization tuple and set the delegation destination. We are able to compute a fair cost for this operation by reviewing its impact on the system:
+
+* ferry 101 bytes of calldata = `101 * 16 = 1616`


Nit: I see where the 101 comes from (flat bytes of the authority tuple) but this is not super clear. 16 is calldata gas cost for nonzero bytes.

jochem-brouwer · 2024-10-09T16:15:53Z

EIPS/eip-7702.md

+The `PER_AUTH_BASE_COST` is the cost to process the authorization tuple and set the delegation destination. We are able to compute a fair cost for this operation by reviewing its impact on the system:
+
+* ferry 101 bytes of calldata = `101 * 16 = 1616`
+* recovering the `authority` address = `3000` 


Maybe add a note that this is ecrecover precompile cost?

jochem-brouwer · 2024-10-09T16:20:09Z

EIPS/eip-7702.md

+
+* ferry 101 bytes of calldata = `101 * 16 = 1616`
+* recovering the `authority` address = `3000` 
+* reading the nonce and code of `authority` = `5000`


Where does the 5000 cost come from? (If I would check cold extcodecopy I pay 2600 gas, and then nonce can be directly read since we have to read the account RLP (which contains the nonce))

jochem-brouwer · 2024-10-09T16:21:20Z

EIPS/eip-7702.md

+
+For most intents and purposes, an account delegated to `0x0` is indistinguishable from a true EOA. However, one particular unfortunate case is unavoidable. Even if a user has a zeroed out delegation designation, most operations that interact with that account will encounter an additional `COLD_ACCOUNT_READ_COST` upon the first touch. 
+
+This is not ideal and may be a significant enough concern to impact the overall adoption of the EIP. For these reasons, we have opted to include a mechanism which allow users to restore their EOA to its original pureness.


This is a super great addition 😄 👍

#12666) See ethereum/EIPs#8929

github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels Oct 3, 2024

eth-bot changed the title ~~7702: restrict field sizes~~ Update EIP-7702: restrict field sizes Oct 3, 2024

etan-status approved these changes Oct 4, 2024

View reviewed changes

LookNowThis approved these changes Oct 5, 2024

View reviewed changes

poojaranjan mentioned this pull request Oct 8, 2024

Ethereum Cat Herders Meeting #139 ethcatherders/PM#416

Open

3 tasks

lightclient added 3 commits October 8, 2024 14:51

7702: restrict field sizes

3e5de77

7702: update cost of auth, add mechanism to fully clear delegation

9a9256e

7702: add more rationale

7d7f09a

lightclient force-pushed the 7702-devnet-4 branch from a0b6f6f to 7d7f09a Compare October 9, 2024 13:45

etan-status reviewed Oct 9, 2024

View reviewed changes

EIPS/eip-7702.md Outdated Show resolved Hide resolved

7702: typo

9d4d17a

lightclient marked this pull request as ready for review October 9, 2024 14:35

lightclient requested a review from eth-bot as a code owner October 9, 2024 14:35

eth-bot enabled auto-merge (squash) October 9, 2024 14:36

eth-bot approved these changes Oct 9, 2024

View reviewed changes

eth-bot merged commit 8628167 into ethereum:master Oct 9, 2024
11 checks passed

jochem-brouwer reviewed Oct 9, 2024

View reviewed changes

ethereum deleted a comment from GIgako19929 Oct 9, 2024

lightclient changed the title ~~Update EIP-7702: restrict field sizes~~ Update EIP-7702: updates for devnet4 Oct 9, 2024

lightclient mentioned this pull request Oct 9, 2024

Update EIP-7702: fixup gas costs and empty code hash #8948

Merged

marioevz mentioned this pull request Oct 9, 2024

feat(fw,tests): EIP-6110, EIP-7002, EIP-7251, EIP-7702: Pectra Devnet-4 updates ethereum/execution-spec-tests#832

Merged

25 tasks

jochem-brouwer mentioned this pull request Oct 10, 2024

vm/tx: update 7702 to devnet-4 ethereumjs/ethereumjs-monorepo#3737

Merged

2 tasks

somnathb1 mentioned this pull request Oct 22, 2024

Implement pectra-devnet-4 changes erigontech/erigon#12106

Closed

12 tasks

yperbasis mentioned this pull request Oct 29, 2024

Double check EIP-7702 and txpool erigontech/erigon#11763

Open

yperbasis mentioned this pull request Nov 7, 2024

EIP-7702 authorization: limit chain_id to uint64 and y_parity to uint8 erigontech/erigon#12666

Merged

yperbasis added a commit to erigontech/erigon that referenced this pull request Nov 7, 2024

EIP-7702 authorization: limit chain_id to uint64 and y_parity to uint8 (

f475cc4

#12666) See ethereum/EIPs#8929

somnathb1 pushed a commit to erigontech/erigon that referenced this pull request Nov 8, 2024

EIP-7702 authorization: limit chain_id to uint64 and y_parity to uint8 (

36c7436

#12666) See ethereum/EIPs#8929

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update EIP-7702: updates for devnet4 #8929

Update EIP-7702: updates for devnet4 #8929

lightclient commented Oct 3, 2024

eth-bot commented Oct 3, 2024 •

edited

Loading

jochem-brouwer commented Oct 3, 2024 •

edited

Loading

eth-bot left a comment

eth-bot left a comment

jochem-brouwer Oct 9, 2024

lightclient Oct 9, 2024

jochem-brouwer left a comment •

edited

Loading

jochem-brouwer Oct 9, 2024

jochem-brouwer Oct 9, 2024

jochem-brouwer Oct 9, 2024

jochem-brouwer Oct 9, 2024


		The `PER_AUTH_BASE_COST` is the cost to process the authorization tuple and set the delegation destination. We are able to compute a fair cost for this operation by reviewing its impact on the system:

		* ferry 101 bytes of calldata = `101 * 16 = 1616`


		For most intents and purposes, an account delegated to `0x0` is indistinguishable from a true EOA. However, one particular unfortunate case is unavoidable. Even if a user has a zeroed out delegation designation, most operations that interact with that account will encounter an additional `COLD_ACCOUNT_READ_COST` upon the first touch.

		This is not ideal and may be a significant enough concern to impact the overall adoption of the EIP. For these reasons, we have opted to include a mechanism which allow users to restore their EOA to its original pureness.

Update EIP-7702: updates for devnet4 #8929

Update EIP-7702: updates for devnet4 #8929

Conversation

lightclient commented Oct 3, 2024

eth-bot commented Oct 3, 2024 • edited Loading

jochem-brouwer commented Oct 3, 2024 • edited Loading

eth-bot left a comment

Choose a reason for hiding this comment

eth-bot left a comment

Choose a reason for hiding this comment

jochem-brouwer Oct 9, 2024

Choose a reason for hiding this comment

lightclient Oct 9, 2024

Choose a reason for hiding this comment

jochem-brouwer left a comment • edited Loading

Choose a reason for hiding this comment

jochem-brouwer Oct 9, 2024

Choose a reason for hiding this comment

jochem-brouwer Oct 9, 2024

Choose a reason for hiding this comment

jochem-brouwer Oct 9, 2024

Choose a reason for hiding this comment

jochem-brouwer Oct 9, 2024

Choose a reason for hiding this comment

eth-bot commented Oct 3, 2024 •

edited

Loading

jochem-brouwer commented Oct 3, 2024 •

edited

Loading

jochem-brouwer left a comment •

edited

Loading