Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create EIP 191 #973

Merged
merged 1 commit into from
Apr 5, 2018
Merged

Create EIP 191 #973

merged 1 commit into from
Apr 5, 2018

Conversation

Arachnid
Copy link
Contributor

@Arachnid Arachnid commented Apr 5, 2018 •
edited
Loading

Replaces #191.

@Arachnid Arachnid requested a review from holiman April 5, 2018 12:41
@holiman
Copy link
Contributor

holiman commented Apr 5, 2018

Sgtm!

@Arachnid Arachnid merged commit 70f7c10 into ethereum:master Apr 5, 2018
@Arachnid Arachnid deleted the 191 branch April 5, 2018 16:04
@ligi ligi mentioned this pull request Apr 6, 2018
Closed
@3esmit 3esmit mentioned this pull request Apr 9, 2018
Merged
@3esmit
Copy link
Contributor

3esmit commented Apr 9, 2018

Can we make the signed data standard a "solidity default method", or we would have to stick to libraries? Maybe signHash(bytes32) return data signed in standard? or even make signHash accept multiple n arguments and make all easy? :)

Not sure if place to open another EIP for this or open some issue in solidity after this EIP is merged?

@Arachnid
Copy link
Contributor Author

Arachnid commented Apr 9, 2018

Opening an issue in Solidity would be best, but I'm not sure it's justified - keccak256('\x19\x00', this.address, data) works just fine.

Arachnid added a commit to Arachnid/EIPs that referenced this pull request May 2, 2018
@Arachnid
Create EIP 191 (ethereum#973)
8f8b68d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman Awaiting requested review from holiman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arachnid @holiman @3esmit