Add ERC: Encode chain id with transaction hash #1036
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eip-review-bot
changed the title
|
The automatic file name check keeps failing, but I don't understand why. My file is not named like the error claims and the format should be ok (the name is "erc-encode-idhash.md"). |
bomanaps
reviewed
May 12, 2025
|
|
||
| An example for a transaction with hash `0xc55e2b90168af6972193c1f86fa4d7d7b31a29c156665d15b9cd48618b5177ef` that was issued on chain ID `1` is: `1:0xc55e2b90168af6972193c1f86fa4d7d7b31a29c156665d15b9cd48618b5177ef:tx`. | ||
|
|
||
| The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED", "MAY", and "OPTIONAL" in this document are to be interpreted as described in RFC 2119 and RFC 8174. |
There was a problem hiding this comment.
You mean the second part about MUST etc? I don't think I should remove the example.
lightclient
reviewed
May 22, 2025
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
microbecode
changed the title
eip-review-bot
changed the title
|
It was suggested to switch this to the EIP side. Added a new PR here. will close this once that PR gets processed. |
|
The commit 669d585 (as a parent of a60c144) contains errors. |
53 tasks
|
Replaced by ethereum/EIPs#9804 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion for a new standard.
This standard proposes a way to encode the combination of a chain ID and a transaction hash into one string.
P.S. Resubmitting as a new PR (old closed PR at #1035) to try if the automatic file check passes this time.