Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Phase 1] get_custody_chunk_count is broken #1034

Closed
hwwhww opened this issue May 3, 2019 · 1 comment
Closed

[Phase 1] get_custody_chunk_count is broken #1034

hwwhww opened this issue May 3, 2019 · 1 comment
Labels
general:bug Something isn't working phase1

Comments

@hwwhww
Copy link
Contributor

hwwhww commented May 3, 2019

Issue

In get_crosslink_chunk_count function, it uses attestation.data.latest_crosslink.epoch to calculate crosslink_crosslink_length, but attestation.data.latest_crosslink.epoch field is missing after #874.

@hwwhww hwwhww added the phase1 label May 3, 2019
@vbuterin
Copy link
Contributor

vbuterin commented May 4, 2019

The best solution I can come up with is to have the number of slots in the crosslink be explicitly listed in the attestation.

(Best to do it as a number of slots, because then we can most easily argue that it's the item length of an SSZ array of flattened block objects, so one could hash together the item length and root to get the SSZ root of the flattened block objects as a dynamic-sized list)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general:bug Something isn't working phase1
Projects
None yet
Development

No branches or pull requests

4 participants